Giter Club home page Giter Club logo

Comments (14)

Shivang-Bhandari avatar Shivang-Bhandari commented on September 7, 2024 1

yeah sure ill get to it and check where things are going off track, i hope by the end of the weekend ill be able to resolve the issue @jig08 .

from fossasia.org.

mariobehling avatar mariobehling commented on September 7, 2024 1

We can also think about another solution, but it sounds like the easiest to go with for now.

from fossasia.org.

Shivang-Bhandari avatar Shivang-Bhandari commented on September 7, 2024

2

from fossasia.org.

jigyasa-grover avatar jigyasa-grover commented on September 7, 2024

@Shivang-Bhandari Help us resolve the issue pls.

from fossasia.org.

Shivang-Bhandari avatar Shivang-Bhandari commented on September 7, 2024

@jig08 i have fixed the issue.

from fossasia.org.

Shivang-Bhandari avatar Shivang-Bhandari commented on September 7, 2024

@mariobehling The issue is that there is an additional white space in the whole page due to which the hamburger icon is not displayed fully and the user has to scoll a bit horizontally as visible in the screenshot previously attached. After looking into the home page i found that this was being caused due to the footer elements going out of place. I am attaching screenshots of the navbar display as well as the footer as they are on fossasia.org kindly take a look at them.
navbar
footer

from fossasia.org.

Shivang-Bhandari avatar Shivang-Bhandari commented on September 7, 2024

@mariobehling the issue can only be resolved by changing the width of the elements in the footer as the email address's unusual width is causing the issue in the first place.

from fossasia.org.

mariobehling avatar mariobehling commented on September 7, 2024

@Shivang-Bhandari Thanks for pointing this out. Please try to play around with css, e.g. a result could be that in smaller resolutions the page shows "fossasia@google...." instead of the full email.

from fossasia.org.

Shivang-Bhandari avatar Shivang-Bhandari commented on September 7, 2024

@mariobehling rather than hiding the whole email address wouldn't it be better to fit it in the page itself by adjusting the classes for smaller resolutions like i did in my commit which was reverted ?

from fossasia.org.

mariobehling avatar mariobehling commented on September 7, 2024

Your adjustments changed the width distribution of the footer columns. This is not a desired outcome as the footer should be distributed evenly. Cheers.

from fossasia.org.

Shivang-Bhandari avatar Shivang-Bhandari commented on September 7, 2024

@mariobehling Ok sir so should i make changes to hide the whole email address for the smaller screen resolutions ?

from fossasia.org.

Shivang-Bhandari avatar Shivang-Bhandari commented on September 7, 2024

@mariobehling Sorry for the late reply but i am thinkig that it would be a better idea to put Just 'FOSSASIA' instead of the whole link and then add a mailto link to it which would be much more convinient for the users too.

from fossasia.org.

Shivang-Bhandari avatar Shivang-Bhandari commented on September 7, 2024

if you feel the idea would be ok then i'll get it done asap

from fossasia.org.

mariobehling avatar mariobehling commented on September 7, 2024

@Shivang-Bhandari This field is an email field. So, Email address there is the preferred solution. As this is quite a long discussion about a small issue, I am opening this issue to others and unassigning this. If you still think you can solve it, simply make a pull request. Cheers.

from fossasia.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.