Refactor models/payment_histories.rb to be more readable and maintainable (it's WILD at the moment 😅)

• Move the logic for calculating the metrics into a metric::calculator class
• Split the CSV import into separate class
• Split the Partner API import into separate class
• Update the Worker/Job to use the new classes etc.
• Add tests

Requires Rails > 5.2

Hi,

I noticed that the "Revenue per country" pie chart data is a little bit off https://gyazo.com/78c3dd580a525409038ef3752422743d
It looks like it does not get data from Shopify.
Is it fixable or its just because of lack of data?

PS: I love Partner Metrics :)

I'm a human. Please be nice.

• Update workers to ActiveJob
• Replace resque & resque-pool with sidekiq
• Add basic tests for jobs

We allow the user to upload a single CSV file for importing historical payment data. Currently it uses a js library and S3 for this, but that makes development & test harder. We'd like to replace this with ActiveStorage. Production should still use S3 (via ActiveStorage) but a simpler (local?) solution for dev and test would be really nice.

The files are quite large so we should use direct_upload feature from ActiveStorage if possible.

The user can upload either the zipped or unzipped file for storage.

We should setup a rake task to purge/destroy attached files (which will run daily in production) as the files is only needed during actual import and calculation, which happens just after upload.

uploading a new file replaces the existing file. So it would be has_one_attached

Big one, but would be great to support metrics based off the AppEvents endpoint from the Partner API.

Ideas

Use an Events model, for all types, including payments. So convert Payments and AppEvents into a single format.

Event types

• Installed
• Uninstalled
• Converted
• Paid
• Acquired
• Retained
• Expanded
• Reactivated
• Contracted
• Churned
• Refunded

Note: A single app event or payment from shopify can result in multiple of the events above. For example “Uninstalled” may also create a “Churned” event if it was a previously paying shop.

Some events must be generated via a calculation, meaning all data must be present before those can be done correctly. Perhaps a processing pipeline lile this:

• Import from CSV (historical revenue numbers only)
• Import payments from API
• Import events from API
• Generate calculated events for these newly imported records
• Calculate rollup metrics for each day

Events model

• Date
• Revenue type (monthly, yearly, onetime, usage, none)
• Event type (from list above)
• Shop (association)
• App (association)
• Gross amount
• Shopify fee ampunt
• Net amount
• Calculated (true/false) -> Maybe needed for 2 step import + creating of additional event types..like Churned etc.

Rollup to Metric model

Events give us enough information to then
calculate daily aggregated records (with dimensions of revenue type, app & event type) for each final metric we want to display.

Monthly MRR
Monthly Churned MRR.
Monthly LTV
Monthly MRR expansion revenue
Yearly ARR…

We still don’t have a great way to track trials, BUT we can show Installs to paid conversions and “new” revenue metrics, which should be good enough.

One issue we will run into is that bootstrap gem is not available for newer rails versions. Perhaps we can precompile the bootstrap css asset (it uses variables and so needs to be compiled), then copy the generated file into a static CSS file in /app/assets/stylesheets. That allows us to remove the bootstrap gem, but keep a working stylesheet until we are ready.

Upgrade of Rails files diff: https://railsdiff.org/4.2.11.3/7.0.7.1

LOVE PARTNERMETRICS JUST ONE ISSUE

Issue Description

On the "Shop Summary" page of our application, the table that displays the list of active merchants is currently limited to showing only 100 rows. This is problematic as we have over 400 merchants, and there seems to be no option or feature to navigate to the next set of rows (pagination) to view the rest of the merchants.

Steps to Reproduce

1. Log in to the application.
2. Navigate to the "Shop Summary" section.
3. Observe the displayed table of active merchants.

Expected Behavior

The table should offer pagination controls (like next, previous page buttons) or some other mechanism to view all merchants, especially when their number exceeds the currently displayed limit of 100.

Actual Behavior

Only 100 merchants are displayed with no apparent way to access the remaining merchants.

Additional Information

• Total number of merchants: 400+
• Currently displayed: 100

I'm a human. Please be nice.

I can get bin/dev to work fine, but when I switch to production, it always crashes asking for these additional logins. Any ways to run it bare bones on production?

Having this available will make adding things like turbo, stimulus and other good stuff so much easier. Once we have stimulus we can remove jQuery dependencies etc as well 😎

Is esbuild the go to for rails projects these days?

https://github.com/ankane/prophet-ruby

1. Add user setting for “show_forecast”
2. Update “chart_data” endpoint to add forecast if enabled.

Requires Ruby >= 2.7 .. so will need to wait for that

I cloned the app and tried to run it for the first time but I keep getting the error below after running bin/setup

rails aborted!
NoMethodError: undefined method []' for nil:NilClass /Users/keem/projects/partner-metrics/config/application.rb:36:in class:Application'
/Users/keem/projects/partner-metrics/config/application.rb:22:in <module:PartnerMetrics>' /Users/keem/projects/partner-metrics/config/application.rb:21:in

'
/Users/keem/projects/partner-metrics/Rakefile:4:in require_relative' /Users/keem/projects/partner-metrics/Rakefile:4:in '
bin/rails:4:in `'
(See full trace by running task with --trace)

== Command ["bin/rails db:prepare"] failed ==

The error seems to point to the line below

config.active_record.encryption.primary_key = Rails.application.credentials[:active_record_encryption][:primary_key]

Any idea how I fix this ? Do I need to change the value in the credentials file ?

Current only a single user can view their data. It's often requested by users that we introduce an Account model, so multiple users can login to the same account. On signup first user fills out the Partner Organization Name, which creates the account.

Some initial thoughts:

• All metrics & payments would need to be associated with the Account level instead of user
• Migrate all existing data to the Account model structure
• First user is an Admin, and can choose if others are admin
• Only admin can update account level features (api credentials, upload data, invite other users etc.)
• As we will have limited features related to admin permissions, I don't think we should add dependencies on CanCanCan or other Role based gems.

• I added my partner API credentials, Is there a button I should push to sync?
• No where does it show which app I am looking at the numbers for
• How do I switch between partner apps in the dashboard

I'm a human. Please be nice.

• Move things to correct model
• DRY up repeated code
• Refactor long methods
• Use scopes where possible
• Add basic tests

• Move things to correct RESTful controllers/actions
• DRY up repeated code
• Refactor long methods
• Add basic tests

Hello Team,

I'm trying to set up this app on a linux machine.

Server details:

PRETTY_NAME="Ubuntu 22.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.3 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

Problem statement:

When I execute the bin/dev command as mentioned in the readme.md file, then I can see this error

Sideqik is trying to connect with Redis but it's not connected successfully.

Requires Rails > 5.1

When importing from the Shopify Partner API via GraphQL, the import_partner_api method does not include the shop_country when creating the PaymentHistory records, which results in the app showing NULL:

The initial CSV import does include shop_country so we see it after initial import, but then NULL starts creeping in more and more over time as the payments are imported from the API daily.

Note: There is no way to fix this, as the Shopify Partner API does not provide the shop country information: https://shopify.dev/docs/api/partner/2023-10/objects/Shop

We had the same issue with some internal tools getting this 404 error the last 3 days and was because we were using the API 2023-07 and not the 2024-07.

I'm a human. Please be nice.

Thanks a lot for the platform. I've been looking for a tool like this since quite some time.

I am trying to import my payouts data inside the platform. Everytime I do it, looks like the page is breaking and I can see the errors in the Console/Network tabs. Here's what the platform looks like after a broken import:

Steps to reproduce

1. In Shopify, click on Export CSV and export All Payouts
2. Upload the received CSV in https://www.partnermetrics.io/imports/new
3. See the broken pages and no new data.

I also tried to ZIP the CSV because the box was telling to use a ZIP. Thanks!

It would be great to support a Note marker style feature, where you can add notes to graphs on certain dates. For example, you may want to add a note marker on the date that you made a pricing change or update your Shopify App Store listing.

• Add a note marker resource (date, note text, optional association to to specific app_title). index, new, create, update, destroy.
• User option to include note markers on main graph
• Update main chart to show the note markers as vertical line marker, with hover showing text

See screenshot

GraphQL is only used in one place, models/payment_histories.rb

It would be great to clean up the implementation, to make it less "noisy" in the file. Ideas:

• Move GraphWL Query and response parser to it's own folder/files. Great example at: github.com/kirillplatonov/shopify_graphql
• Add basic tests
• If possible, update graphql schema + bump Shopify api version

I only just noticed that all the imports are failing ever since October 1. Prior to that it was working fine.

Currently, the app will treat usage charges as one-time payments. This is technically correct, but in some cases the user may want those usage charges counted as recurring revenue. I do this myself, as one of my apps uses usage charges for the actual subscription charge, depending on amount of use. Now I also have another user that wants the same, and so it may make sense to have this as an option.

1- On the Account connection modal, under the api credentials, we have a radio form control:

a) Count "usage charges" as one-time revenue
b) Count "usage charges" as recurring revenue

a) is the default for new accounts

This then saves to the current_user along with the other credentials, and checked when importing payments. Currently I have some rough logic that does this, based on my email address. This could be replaced with a check against the above field instead.

• Remove unused gems
• Cleanup Gemfile structure

Hi @forsbergplustwo
After execution of import_all_from_partner_api , i can see import status is set as scheduled in APP

Can you please let me know badge status will set completed automatically and data will import in APP or i need to execute other command?