Cannot read property 'props' of undefined about victory HOT 6 CLOSED

@carbonrobot

I had same issue when doing some package upgrades. It was solved by modifying how I was using "containerComponent" prop.

//Before

<VictoryChart containerComponent={tooltipLabel ? <VictoryVoronoiContainer/> : undefined} >{...}</VictoryChart>

//After

<VictoryChart containerComponent={tooltipLabel ? <VictoryVoronoiContainer/> : <VictoryContainer/>} >{...}</VictoryChart>

It looks like you no longer include VictoryContainer by default if "containerComponent" is undefined.

from victory.

I stumbled across this issue too. I confirm what @bretthadley said, if containerComponent is undefined, there is an app crash in React Native.

from victory.

Hi @KelvinPortuphy, do you have some sample code so we can reproduce the issue?

Here is the template for submitting a big report. It helps us solve the issue for you quicker. https://github.com/FormidableLabs/victory/blob/main/.github/ISSUE_TEMPLATE/bug_report.md

from victory.

@carbonrobot
that would hard to do because we use it in quiet a number places in our app,
and I have moved on because of tight deadlines

but I noticed replacing
var componentStyle = titleComponent.props && titleComponent.props.style || {};
with
var componentStyle = titleComponent?.props && titleComponent?.props?.style || {};

on line 205 fixed the issue.

from victory.

Ok, we will close the issue until you are able to provide some information on your usage.

from victory.

Thanks for the additional info @bretthadley and @Kerumen.

This component uses default props for that property so undefined would definitely throw an error. I'll review our docs to make sure we cover this use case.

from victory.