forge / docker-addon Goto Github PK

What happens if the type is not in the specified enum?

A rule based 'linter' Dockerfiles .The linter rules can be used to check file syntax as well as arbitrary semantic and best practice attributes determined by the rule file writer.Rule files are written in YAML.

public void addValidationResult(String type, String message, String line, Integer lineNumber) and public void addValidationResult(String type, String message) should be removed.

testDockerfileSetup(org.jboss.forge.addon.docker.ui.DockerfileSetupCommandTest).

The Docker Addon has to provide APIs and services for interacting with real and virtual Dockerfile Resources, typically for the purpose of reading and manipulating Dockerfiles.
The addon should use Shrinkwrap Descriptors Docker, that provide reading,parsing,manipulating
and writing Dockerfile commands to real and virtual Dockerfile resources provided by the addon.

docker build -t "tag" . is parsed as docker build tag .

There are two files that do not belong to the project. They must be removed

See logs at https://travis-ci.org/forge/docker-addon

DockerfileValidationImpl should be hidden from the API consumer and therefore should only be accessed through DockerFileResource.verify(). The tests should be changed to use that. Maybe the class name should be changed as well.

Consumers of this addon must not have access to impl classes

Specifically the APIs should all have clear javadocs.
Implementation classes on the other hand should only have comments when you need to explain "why" a decision was made.

I noticed that in your tests, the @Deployment method contains specific @AddonDependency entries. Is there any reason to do so? Normally you should only declare @AddonDependency entries if they are not declared in the pom.xml or you need a different environment for testing your addon (I believe this is not the case).
This is how a @Deployment method should look like in most cases:

   @Deployment
   @AddonDependencies
   public static AddonArchive getDeployment()
   {
      return ShrinkWrap.create(AddonArchive.class).addBeansXML();
   }

This will make sure that the addon to be tested uses the dependencies declared in your pom.xml

https://github.com/shrinkwrap/descriptors-docker