folded-php / history Goto Github PK

Description

The history do not store the query strings.

Reproduce the issue

1. Try to browse an URL with a query string
2. Go back
3. You go back to the previous URL without query strings

Expected behavior

To go back with query strings if the URL contained query strings.

Actual behavior

Going back to an URL will ignore query strings.

Alternatives solutions

None.

Notes

Description

folded/exception 0.3 is released.

Expected behavior

This package uses folded/exception 0.3.

Actual behavior

This package uses folded/exception 0.1.

Alternatives solutions

None.

Notes

Description

The history class is not meant to be extended.

Proposal

To mark the History class as final.

Worarkound solutions

None.

Notes

None.

Description

When the code loads functions, it should detect the existance of the function under the namespace instead of just the name of the function

Expected behavior

The call of function_exists() use the full qualified namespace.

namespace Folded;

if (!function_exists("Folded\theFunction")) {
  // load the function now
}

Actual behavior

Functions declared twice enters in collision.

Alternatives solutions

None.

Description

Static analysis helps catching bugs earlier.

Proposal

• Using phpstan/phpstan and run the command after the test command: pest --coverage && phpstan analyse src
• Use the level 8 for a maximum of consistency
• Use a phpstan.neon configuration file

Worarkound solutions

None.

Notes

None.

Description

The server will sometimes try to get /favicon.ico, but this should not be stored as it's not an HTML URL.

Expected behavior

To not store non-html URLs.

Actual behavior

URLs that are not HTML documents are stored in the history.

Alternatives solutions

None.

Description

There is no templates for bugs and enhancements, which can reduce the chances someone will want to describe his issue or can make difficult to format and clarify an issue without proper templates.

Expected behavior

Enhancements issue template

For an enhancements, the following sections (using level 2 title, ##) should be shown:

• Description
• Proposal
• Workaround solutions
• Notes

The text hints, using italic, should be shown below each of these titles (without the double quotes):

• Description: "Give some context and motivation for the proposed solution."
• Proposal: "The detail proposition. Can include code."
• Worarkound solutions: "Mention every existing workaround you know that will solve the issue apart from the proposed solution."
• Notes: "Add everything that relates the proposal, like future induced issues, related issues, ..."

Bug issue template

For a bug, the following sections (using level 2 title, ##) should be shown:

• Description
• Steps to reproduce the issue
• Expected behavior
• Workaround solutions
• Notes

The text hints, using italic, should be show below each of these titles (without the double quotes):

• Description: "Any information that can give more understanding about how you came to this issue."
• Steps to reproduce the issue: "Detail precisely how we can reproduce the issue from a blank new project (if possible)."
• Expected behavior: "Describe what the output or the behavior should be instead of the issue you have."
• Workaround solutions: "Mention every existing workaround you know that will solve the issue."
• Notes: "Add everything that relates the proposal, like related issues, ..."

Alternatives solutions

To write by hand the issue layout.

Description

This package uses an old version of folded.

Proposal

Upgrade to folded/exception:0.4.*

Worarkound solutions

Notes