Comments (4)
Another issue I have just come across is elements that are projected using <slot>
are not picked up in the tab order and therefore cannot be tabbed to. Those DOM trees are not traversed because they live in the light DOM and are just rendered in the slot location within the shadow dom. This also has to do with tabbable
and it would have to be updated to find any children that are slot elements, and traverse the value returned from each [slotNode].assignedNodes()
call.
from focus-trap.
@DRiFTy17: I'm open to PRs fixing these libraries for usage with the shadow DOM. I am not currently using web components and don't think I will be for some time, so I won't lead the way here. Sounds like you have some promising ideas 👍
from focus-trap.
@davidtheclark Okay let me see what I can put together, and I'll try to work out the various issues to get this supported. I'll submit the PRs when I get things complete.
from focus-trap.
With v3 (involving some changes to Tabbable) you should be able to include shadow DOM nodes or iframes or whatever in the middle of the focus-trap. Things will get weird if you include those things as the first or last tabbable nodes in the trap. This caveat is now documented in the readme.
So I'm going to close this issue. If anybody comes up with implementation changes that might rid us of that caveat, please open a new issue or PR.
from focus-trap.
Related Issues (20)
- Adjust types to allow `initialFocus: () => undefined` HOT 4
- Bug with selecting jumping to first tabbable from last if web component is involved. HOT 5
- Nesting focus traps? HOT 2
- Demo: in "hidden treasures" there is no way to deactivate the trap HOT 4
- Cannot tab on to or past a web-component in a container HOT 6
- Setting initialFocus=true leads to a call stack exceeded exception HOT 2
- More Flexible Mocking in Unit Tests HOT 3
- The library is not working HOT 3
- Should focusTrap only activate connected nodes? HOT 3
- Broken in Safari HOT 4
- focusIn listener causes issues with outside elements HOT 15
- Stack overflow tryFocus/checkFocusIn HOT 10
- Can't focus other textfields while focusing on autocomplete HOT 2
- Text selection within trapped element not possible if any ancestor has a `tabindex` HOT 9
- `returnFocusOnDeactivate` not working on mobile. HOT 9
- Focus does not seem to be working on firefox HOT 6
- Update type for document option to allow for shadowRoot elements. HOT 7
- "default behavior" demo broken on Firefox HOT 4
- Clicking another shadowed element inside the focus trap will deactivate the focus trap HOT 15
- focus-trap returns an error on Safari 15.3 and lower HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from focus-trap.