Giter Club home page Giter Club logo

Comments (4)

DRiFTy17 avatar DRiFTy17 commented on June 20, 2024

Another issue I have just come across is elements that are projected using <slot> are not picked up in the tab order and therefore cannot be tabbed to. Those DOM trees are not traversed because they live in the light DOM and are just rendered in the slot location within the shadow dom. This also has to do with tabbable and it would have to be updated to find any children that are slot elements, and traverse the value returned from each [slotNode].assignedNodes() call.

from focus-trap.

davidtheclark avatar davidtheclark commented on June 20, 2024

@DRiFTy17: I'm open to PRs fixing these libraries for usage with the shadow DOM. I am not currently using web components and don't think I will be for some time, so I won't lead the way here. Sounds like you have some promising ideas 👍

from focus-trap.

DRiFTy17 avatar DRiFTy17 commented on June 20, 2024

@davidtheclark Okay let me see what I can put together, and I'll try to work out the various issues to get this supported. I'll submit the PRs when I get things complete.

from focus-trap.

davidtheclark avatar davidtheclark commented on June 20, 2024

With v3 (involving some changes to Tabbable) you should be able to include shadow DOM nodes or iframes or whatever in the middle of the focus-trap. Things will get weird if you include those things as the first or last tabbable nodes in the trap. This caveat is now documented in the readme.

So I'm going to close this issue. If anybody comes up with implementation changes that might rid us of that caveat, please open a new issue or PR.

from focus-trap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.