Giter Club home page Giter Club logo

Comments (4)

stefcameron avatar stefcameron commented on June 23, 2024 1

In the live demo of "hidden treasures" there is no way to deactivate the focus trap.

Hi, @DaviDevMod, thanks for keep an eye on the demos.

Screen Shot 2022-02-18 at 8 48 18 AM

I suppose that sentence isn't visible enough, or that since all other demos have a "deactivate" button, you're prone to expect one here. The point was to show at least one demo where an explicit button to deactivate isn't necessary for a focus-trap to work.

Maybe we could put the sentence in a new paragraph, or make it bold, so it's more obvious?

from focus-trap.

stefcameron avatar stefcameron commented on June 23, 2024 1

Thank you! I appreciate that. 😄

Could you update your PR to add the bold formatting? Maybe also putting that short sentence in a new paragraph would help draw additional attention to it.

from focus-trap.

DaviDevMod avatar DaviDevMod commented on June 23, 2024

Oh, I am sorry. I didn't read the description.

I just assumed from the title "hidden treasures" that the demo was about showing that the trap still works even when new elements appear inside of it.

I guess that no changes are needed, it's only required that the user reads that short sentence.

Maybe putting a word in bold could help by encouraging to read the related text.

In any case I apologise for the inconvenience and I take the occasion to thank you for maintaining this open source project from which I am learning a lot.

Have a great day.

from focus-trap.

DaviDevMod avatar DaviDevMod commented on June 23, 2024

Yes, I'd love to update my PR.

I will do it as soon as I get back home.

from focus-trap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.