Comments (4)
Thank you for trying out the branch planner.
While @yitsushi could be the best person right now to point out where to fix, but the project is now 100% community driven.
PRs are always welcome from community members like you @hirenko-v
from tofu-controller.
and seems like it does plan for all open PRs despite on the repo config
Branch planner does not filter on target branch, and as I remember, it never did. That's not a good behaviour, but I don't think we had that use-case in mind (PRs can be opened against other branches and people may use it).
If it did not create PRs previously, that was an bug not a feature that time 🤦♀️
from tofu-controller.
@yitsushi I think the behaviour is not correct, it should filter PRs based on branch (ref) in GitRepository, it makes no sense if I have Terraform resource that use main
branch from GitRepository to do plan for PRs opened to staging
branch.
Also good idea is to have changeset filter to make plan on PRs that include changes in directory configured in Terraform CR
from tofu-controller.
That's not a good behaviour, but I don't think we had that use-case in mind (PRs can be opened against other branches and people may use it). (#1263 (comment))
I mean yes... The behaviour is not good. That's what I wrote, but that's the behaviour it has now. Yes I agree it's a missing feature, as we didn't think of this logic when we built it.
I know the "bug not a feature that time" can be confusing, but that was about you mentioned previously it did not do that, and I'm sure it did as we added branch filtering (and we didn't remove it either), therefore if it did not do that in previous releases, it was a bug somewhere else as it was the "how the code works" logic on branch planner.
Also good idea is to have changeset filter to make plan on PRs that include changes in directory configured in Terraform CR
We have that with enablePathScope
, but it's not enabled by default. relevant code
from tofu-controller.
Related Issues (20)
- tfVarsFiles schema is missing from the Helm chart CRDs HOT 2
- Makefile and pipline should have pinned versions of dependencies HOT 2
- Branch planner does not comment of PR if plan failed due to post plan web hook HOT 1
- Branch Planner Fails due to missing create & delete RBAC for gitrepositories
- Documentation: better documentation on the differences between vars and values.
- Helm chart 0.16.0-rc.4 issue with runner-discovery-service.yaml HOT 2
- Namesapce flux-system is always needed (helm install) HOT 3
- Helm Support for Customizing Tf-Runner HOT 3
- "https://weaveworks.github.io/tf-controller" is not a valid chart repository or cannot be reached HOT 2
- TF-Runner stuck in Terminating state HOT 2
- Finalizer remains despite dependency was deleted HOT 4
- Upgrade Terraform version to v1.6.x for tf-runner HOT 4
- sourceRef using labels HOT 1
- Detect what was applied historically HOT 6
- How to set TF_CLI_ARGS_init
- Tf-runner falls into CrashLoopBackOff state because of unknown flag --grpc-port for tofu-controller command HOT 2
- OSSF scoreboard workflow fails
- Getting `404 Not Found` with terraform HOT 3
- Terraform does not send recovery alert
- Exponentially backoff on reconciliation failure HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tofu-controller.