Finalizer remains despite dependency was deleted about tofu-controller HOT 4 OPEN

I didn't even remember we had issue for this. At least I can't recall any prs fixing finalizers and related to dependencies.

from tofu-controller.

I haven't tested this lately actually, but I'll have to do some stuff at my day job that could trigger this during this week if it's still an issue.

I'll have to see if I can replicate this on the current rc versions, or if it's already been fixed.

@chanwit @yitsushi do you guys know if this has already been fixed in later 0.16 versions?

from tofu-controller.

I didn't even remember we had issue for this. At least I can't recall any prs fixing finalizers and related to dependencies.

Okay, I'm just curious since I haven't run into this specific problem in my environment, which I should have by now. I'll see if I can replicate it somehow.

from tofu-controller.

This one can be related, but that doesn't remove items it just adds. So I don't think that's related, unless tf.ObjectMeta.DeletionTimestamp.IsZero() doesn't work the way it should.
https://github.com/flux-iac/tofu-controller/pull/713/files

I assume we either don't remove references when a resource is deleted, or we have a race condition somewhere (something removed it, but was overwritten by something else because why not). Sadly both cases are equally possible as we don't have a central place to patch and update status for objects.

from tofu-controller.