fluidex / orchestra Goto Github PK

tonic v0.6.1 is available, may not compatible with v0.5.2.

schedule upgrade

Generated files (particularly the .pb-files which are a binaries) should not be part of the version control but created during a build process.

There is no need to keep a version history of these files, as they can be generated at all times, from all (previous) states. In turn they using the versioning pretty messy though if you want to rebase or something, because you'll get a ton of merge conflicts in files that you don't actually care about.

Commit 74deffb introduced a new file envoy-for-mac.yaml alongside the file envoy.yaml.

On top of that, a new file docker/docker-compose-for-mac.yaml was introduced alongside the file docker/docker-compose.yaml. Interestingly enough, these two files are identical. Is there a need for two identical files? Or should there be a difference between the files, e.g. that docker/docker-compose.yaml should refer to ./envoy.yaml instead of ./envoy-for-mac.yaml which it does now?

I don't really understand what mac stands for, but I assume it's meant to mean a computer from Apple. For that reason, since I myself develop on a Linux distro, I personally continued to use the file envoy.yaml instead of envoy-for-mac.yaml. However, there seems to be a problem with the docker networking (which unfortunately I don't understand very well):

I had to change the lines 77, 96 and 116 from 0.0.0.0 to host.docker.internal on my machine for the JS tests to be able to communicate with envoy (particularly the test print-orders.js), but ironically, these lines are the only difference between envoy.yaml and envoy-for-mac.yaml. So changing these values from 0.0.0.0 to host.docker.internal makes the file envoy.yaml identical to the file envoy-for-mac.yaml.

So there seem to be a couple of things wrong here, or I just completely misunderstand the semantics behind these files and am therefore making mistakes (or likely, a combination of both).