fluffy-mods / areaunlocker Goto Github PK

See linked discussion on PRF issue: zymex22/Project-RimFactory-Revived#340

Urgency

Very low -- just causes extra useless entries in the area list.

Problem description
PRF Uses a custom area type for tracking the areas their drones should manage. These areas are normally not visible in the areas list, but Area Unlocker makes them visible.

Describe the solution
The visibility check right now only checks area.Mutable Perhaps we can add another check to ensure they're a default allowed area rather than a custom modded area subclass?

Alternatives
We discussed making the areas immutable on the PRF side, but that doesn't fly since they need to be deleted if the drones-wielding machines are moved or destroyed.

Incompatible with the mod TD Enhancement Pack.

Describe the bug
After the user organizes the areas to his liking when creating a new area or copying a current one the order of the areas will get rearranged to the initial order.

Video: Order bug

Also dragging areas seem to be a problem, they not always drag n'drop properly.

Video: Drag n'drop issue

Expected behavior
When creating a new or copying a area the order of previous created areas should not be changed.

Steps to reproduce
1- Enable TD Enhancement Pack and Area Unlocker in any order, the problem persists.
2- Go to game rearrange areas and create a new one or copy an existing one.
3- Areas will get rearranged to initial order.

Other mods
TD Enhancement Pack

Output log
https://gist.github.com/ed6d36030d6a74597bc07ab08fedfb56

Save game
Any new/old save the problem still persists, but if you really want a save here it is.

Environment

• OS: Windows 10 x64 Enterprise 20H2

Game

• 64 bits
• Steam
• Version: RimWorld 1.2.2900 rev837

I apologize if i should be reporting this bug to TD Enhancement Pack but i'm just not sure.

Reported by: NotooShabby
Description:
Has anyone encountered this issue, when copying area, the new area is blank as if pressing the new area button?

Describe the bug
The only way to confirm a color picked is by selecting and then pressing enter.

Expected behavior
There's supposed to be a button there the confirm.

Steps to reproduce

1. Open color selector in Area tab

Other mods
Lots

Output log
https://gist.github.com/HugsLibRecordKeeper/57fb1018f8aab6996d2a041762c2e5e9

Can I just skip the rest and tell you I fixed the same error for another mod? Apparently the ButtonText widget moved to UnityEngine.TextRenderingModule and adding that as an assembly reference makes the error go away and the button/menus render again.

Reported by: WhiteWolf
Description:
@fluffy; thank you for the fast feedback!

For me it would help a lot even if it is for your mod / vanilla.

Probably the easiest way would be to have a filter in the area with:

- Show All (Default)
- Hide from Colonist
- Hide from Animal

It can also be "Show only" instead of Hide - whatever is easier to implement.

I know vanilla used to have separate areas but that wasn't the perfect solution either. You want some areas to be shared (Show All). Additionally, I haven't encountered many problems before but recent changes to animal meat (Scaria nerf and buff to meat from tame animal) made me push the colony to livestock options. Having multiple types of animals means in some cases a lot of areas defined.

I know you have a lot of things to do but I just wanted to add the comment in case you ever find the time or other people run into similar issues.

https://steamcommunity.com/sharedfiles/filedetails/?id=947972722

luckz 11 Sep @ 2:26pm Delete
"When adding the mod "AreaUnlocker", the heat map didn't work, and all indicators became some sort of a pattern on a certain part of the colony map. Just so you know!"

luckz 11 Sep @ 2:00pm
Somebody posted that this conflicts with https://steamcommunity.com/sharedfiles/filedetails/?id=947972722 and breaks it

After enabling this mod, the roof and mining overlays lose their normal green coloration, and turn into a solid purple cover. In the log, the following message is displayed:

-------- Shader compilation failed
#version 150
#extension GL_ARB_explicit_attrib_location : require
#extension GL_ARB_shader_bit_encoding : enable
uniform 	vec4 hlslcc_mtx4x4unity_ObjectToWorld[4];
uniform 	vec4 hlslcc_mtx4x4unity_MatrixVP[4];
uniform 	vec4 __ST;
in  vec3 in_POSITION0;
in  vec4 in_COLOR0;
in  vec3 in_TEXCOORD0;
out vec4 vs_COLOR0;
out vec2 vs_TEXCOORD0;
vec4 u_xlat0;
vec4 u_xlat1;
void main()
{
    vs_COLOR0 = in_COLOR0;
    vs_COLOR0 = clamp(vs_COLOR0, 0.0, 1.0);
    vs_TEXCOORD0.xy = in_TEXCOORD0.xy * __ST.xy + __ST.zw;
    u_xlat0 = in_POSITION0.yyyy * hlslcc_mtx4x4unity_ObjectToWorld[1];
    u_xlat0 = hlslcc_mtx4x4unity_ObjectToWorld[0] * in_POSITION0.xxxx + u_xlat0;
    u_xlat0 = hlslcc_mtx4x4unity_ObjectToWorld[2] * in_POSITION0.zzzz + u_xlat0;
    u_xlat0 = u_xlat0 + hlslcc_mtx4x4unity_ObjectToWorld[3];
    u_xlat1 = u_xlat0.yyyy * hlslcc_mtx4x4unity_MatrixVP[1];
    u_xlat1 = hlslcc_mtx4x4unity_MatrixVP[0] * u_xlat0.xxxx + u_xlat1;
    u_xlat1 = hlslcc_mtx4x4unity_MatrixVP[2] * u_xlat0.zzzz + u_xlat1;
    gl_Position = hlslcc_mtx4x4unity_MatrixVP[3] * u_xlat0.wwww + u_xlat1;
    return;
}
-------- failed compiling:
vertex shader
0(7) : error C7528: OpenGL reserves names containing '__'

Note: Creation of internal variant of shader 'Custom/Vertex Color' failed.
WARNING: Shader Unsupported: 'Custom/Vertex Color' - Pass '' has no vertex shader
ERROR: Shader Shader is not supported on this GPU (none of subshaders/fallbacks are suitable)WARNING: Shader Unsupported: 'Custom/Vertex Color' - Setting to default shader.

I have attached the full log for more detail, but after about 20 minutes of trial and error, I have narrowed down the source of the problem to the Area Unlocker mod.

For reference, I am playing Rimworld on Gentoo Linux, with the latest nVidia driver (387.22).

rimworld_log.txt

Reported by: mallnibba
Description:
Would including ways to expand/clear areas from the manage areas window be a good idea? It seems silly to have to go to the architect tab when nearly everything else is integrated.

Describe the bug
Error in the console log.

Expected behavior

Steps to reproduce

1. Run the game with the given mod list (exported form RimPy)
2. See the console for errors

Other mods
Mod List

Output log
https://gist.github.com/ceb5e4759805a522d77b3bb2e1be1985

Save game

Screenshots

Environment

• OS: Windows 10
• 64 bit

Game

• 64 bits
• Steam
• Version 1.4.3558 rev334

Describe the bug

I'm unable to to reorder zones. The click and drag feature does not seem to work. Additionally, I am unable to apply colors. I can select and preview colors though.
Expected behavior

I expected to click and drag to reorder the zones. I expected an Apply button. Double clicking and other keybinds do not seem to interact with the mod.
Steps to reproduce

1. Install Mod
2. Start Game
3. Try to reorder zones or change colors
4. Cry (optional)

Other mods

Removed all other mods except Harmony, HugsLib, Rocketman, and XML Extensions before testing and reporting.
Output log

https://gist.github.com/HugsLibRecordKeeper/ee8b4e2bf07f7324751cd97e2a2823dc
Save game

New Arrivals4.zip

Screenshots

Environment

• OS: Windows 10
• 32/64 bits 64 Bit

Game

• 64 bits
• Steam
• Version 1.4.3525

http://imgur.com/a/F8vNB