Giter Club home page Giter Club logo

Comments (9)

hardillb avatar hardillb commented on July 30, 2024 1

@adaptivegarage those annoations also get added to both, they are added to the ingress template for the forge app here and get added as an environment variable here which is then picked up by the kubernetes driver here

from driver-k8s.

hardillb avatar hardillb commented on July 30, 2024

Hello,

We haven't had a need for the either of these just yet with the configurations we've been running with.

All the ingress controllers have automatically worked with WebSockets without the need for an annotation.

And for the TLS we have configured the controller to redirect all traffic to the https port and we've been doing TLS termination at the Ingress Controller with a wildcard certificate, so no need for the tls section or to use things like CertManager just yet.

I hope to merge some changes in the next release that will allow the specifying of extra annotations to make ingress objects which would include the first point.

I'll have a think about the options for setting tls

from driver-k8s.

adaptivegarage avatar adaptivegarage commented on July 30, 2024

Hello,

We haven't had a need for the either of these just yet with the configurations we've been running with.

All the ingress controllers have automatically worked with WebSockets without the need for an annotation.

And for the TLS we have configured the controller to redirect all traffic to the https port and we've been doing TLS termination at the Ingress Controller with a wildcard certificate, so no need for the tls section or to use things like CertManager just yet.

I hope to merge some changes in the next release that will allow the specifying of extra annotations to make ingress objects which would include the first point.

I'll have a think about the options for setting tls

Hi,
thanks for getting back to me.

WebSocket: I am not familiar with all Ingress controllers but Nginx from Nginx (CE edition). And this one requires the annotation to be present in order to support the WS connections. Without the annotation the NodeRED applications complain on failed WS connections.

TLS: I understand that it may work in the scenario you mention. However, in our environment (and I believe we wouldn't be alone) the TLS section needs to be explicitly configured for every Ingress in every namespace. We cannot reconfigure the environment to work as you describe.

Could I perhaps hope that you might consider these suggestions in any near future, or would you appreciate a pull request, that I would take care of, or would you rather suggest that we make our own patch?

Thanks,
regards
Roman

from driver-k8s.

dfulgham avatar dfulgham commented on July 30, 2024

I was having this same issue with websockets, and by adding the annotation for nginx.org/websocket-services into the ingress for the node-red service fixed the issue. So I think there is something needed here.

from driver-k8s.

hardillb avatar hardillb commented on July 30, 2024

@dfulgham You can pass additional ingress annotations as part of the helm install by setting the value ingress.annotations

These should be added to all the instance ingress objects that are created.

from driver-k8s.

adaptivegarage avatar adaptivegarage commented on July 30, 2024

@dfulgham You can pass additional ingress annotations as part of the helm install by setting the value ingress.annotations

These should be added to all the instance ingress objects that are created.

Hi, I would like to refresh and bring to your attention that my comment (and I believe the one from @dfulgham too) referred to the NodeRED instance ingress created by kubernetes.js, not the Flowforge ingress created by helmchart.

from driver-k8s.

adaptivegarage avatar adaptivegarage commented on July 30, 2024

@adaptivegarage those annoations also get added to both, they are added to the ingress template for the forge app here and get added as an environment variable here which is then picked up by the kubernetes driver here

Oh, I see. Thanks a lot, I'll give it a try.
My comment regarding the TLS section is, however, still valid, is that right?

from driver-k8s.

hardillb avatar hardillb commented on July 30, 2024

Yes, TLS entries do still need looking at.

There will be some overlap with some other work we need to look at soon to potentially support custom hostname/domains for instances.

from driver-k8s.

hardillb avatar hardillb commented on July 30, 2024

Cert-Manager TLS support to be added via #131

from driver-k8s.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.