Giter Club home page Giter Club logo

Comments (3)

hardillb avatar hardillb commented on July 30, 2024

Hi @elenaviter support for more docker container repositories is a good idea, but this new regex only matches semver tags, it wouldn't match:

  • flowforge/node-red:latest
  • flowforge/node-red:nightly
  • flowforge/node-red:1.14.0-beta

Needs a little bit more work

from driver-k8s.

elenaviter avatar elenaviter commented on July 30, 2024

Hi @hardillb
True.
What about this?

let validate = '^([a-z0-9][a-z0-9\\-]*(\\.[a-z0-9\\-]+)*\\/)+[a-z0-9\\-]+(?:\\/[a-z0-9\\-]+)*(?::[a-z0-9\\-\\.]+[a-z0-9\\-\\.]*[a-z0-9\\-\\.]+)?$';
let validator = new RegExp(validate);

let val1 = "aiola.jfrog.io/aiola-dev/dc-if/flowforge/node-red:1.13.3";
let val2 = "dc-if/flowforge/node-red:1.13.3";
let val3 = "aiola-dev/dc-if/flowforge/node-red:1.13.3";
let val4 = "flowforge/node-red:1.13.3";
let val5 = "flowforge/node-red:latest";
let val6 = "flowforge/node-red:nightly";
let val7 = "flowforge/node-red:1.14.0-beta";

console.log(validator.test(val1)); // Should be true
console.log(validator.test(val2)); // Should be true
console.log(validator.test(val3)); // Should be true
console.log(validator.test(val4)); // Should be true
console.log(validator.test(val5)); // Should be true
console.log(validator.test(val6)); // Should be true
console.log(validator.test(val7)); // Should be true

from driver-k8s.

hardillb avatar hardillb commented on July 30, 2024

@elenaviter sorry for the delay in getting back to you.

Yes that looks good, if you can do a PR for both this and the Docker driver to keep them in sync I'll get it merged as soon a possible.

from driver-k8s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.