Comments (3)
Hi @elenaviter support for more docker container repositories is a good idea, but this new regex only matches semver tags, it wouldn't match:
flowforge/node-red:latest
flowforge/node-red:nightly
flowforge/node-red:1.14.0-beta
Needs a little bit more work
from driver-k8s.
Hi @hardillb
True.
What about this?
let validate = '^([a-z0-9][a-z0-9\\-]*(\\.[a-z0-9\\-]+)*\\/)+[a-z0-9\\-]+(?:\\/[a-z0-9\\-]+)*(?::[a-z0-9\\-\\.]+[a-z0-9\\-\\.]*[a-z0-9\\-\\.]+)?$';
let validator = new RegExp(validate);
let val1 = "aiola.jfrog.io/aiola-dev/dc-if/flowforge/node-red:1.13.3";
let val2 = "dc-if/flowforge/node-red:1.13.3";
let val3 = "aiola-dev/dc-if/flowforge/node-red:1.13.3";
let val4 = "flowforge/node-red:1.13.3";
let val5 = "flowforge/node-red:latest";
let val6 = "flowforge/node-red:nightly";
let val7 = "flowforge/node-red:1.14.0-beta";
console.log(validator.test(val1)); // Should be true
console.log(validator.test(val2)); // Should be true
console.log(validator.test(val3)); // Should be true
console.log(validator.test(val4)); // Should be true
console.log(validator.test(val5)); // Should be true
console.log(validator.test(val6)); // Should be true
console.log(validator.test(val7)); // Should be true
from driver-k8s.
@elenaviter sorry for the delay in getting back to you.
Yes that looks good, if you can do a PR for both this and the Docker driver to keep them in sync I'll get it merged as soon a possible.
from driver-k8s.
Related Issues (20)
- Contianer pull policy for none :latest tags
- Question about google home HOT 1
- Update to support `credentialSecret` provided by the project
- Pod have default selector even if not set in driver config
- Support setting up custom hostname for project HOT 1
- Move to representing projects as Deployments HOT 1
- Review how we log responses from calls to K8s APIs HOT 3
- Allow 3 replica's per deployment
- Move to using k8s StatefulSets when deploying instances HOT 1
- TLS and WebSocket support in NodeRED instance Ingress (the one created by kubernetes.js) HOT 9
- Editors: allow optional service account linkage
- NodePort services have a limit based on the available ports
- Bump @kubernetes/node-client to 0.18.1
- Race on eventually consistent operations of provision/deprovision of Project's k8s resources [e.g. service, ingress] HOT 4
- Cannot start instance with error: Go struct field EnvVar.spec.template.spec.containers.env.value of type string HOT 4
- Allow CPU bursts for Node-RED pods HOT 3
- Allow Instance Health Check interval to be configured
- Custom k8s environment variables for Node-RED applications HOT 2
- Update K8s nodejs client to 0.19.x as we now target K8s v1.26+ on FF Cloud
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from driver-k8s.