florianbeer / vimrcfu Goto Github PK

Github login returns a white page with;

int(-1)

I have been working on adding sorting functionality to the Browse Snippets page. It works as follows:

• The Browse Snippets page is sorted by ID as is the current convention
• A new Statistics menu is added to the right side. The items in that menu are as follows, with the first three being links, and the last three just displaying a count (as is presently displayed on the index page):
  • By Points
  • By Comments
  • By Date
  • Snippets
  • Comments
  • Users
• The links in the Statistics menu take you to a page with the same formatting as Browse Snippets, but therein the snippets are sorted accordingly
  • There are 10 snippets shown per page
  • Pagination is supported
    • Laravel 4.x does not efficiently support combining groupBy and paginate. For this reason implemented the sorting using manual pagination. See http://laravel.com/docs/4.2/pagination#usage

I think the new Statistics menu could replace the old entirely. Most people probably don't need an option to see Top Snippet as well as a list of all snippets in order of most votes. Same thinking applies to the Most Comments. I didn't make this change, though. Right now there are two different menus (the new and the old), depending on whether the user is on the home page or on the Browse Snippets pages.

strip_tags is vulnerable to cross-site scripting (https://github.com/florianbeer/vimrcfu/blob/master/app/Vimrcfu/Text/Text.php). It does perfectly well in removing tags that are disallowed, but not attributes.

I'd recommend a more stringent regex, only allowing a literal <b> (etc) versus using strip_tags.

For reference: http://vimrcfu.com/snippet/80 and move your mouse anywhere on the page after the "description".

Cheers,
chrsm

It would be nice to have a way to "star" or "favorite" snippets, or just to be able to see the ones that I've upvoted before. That way I can look through and mark the ones I like and then come back and try them out later.

Since you suppost 'some markdown' , it would be good to preview how the markdown would look without having to submit the form.

I want to see the best ones

I would like to be able to flag posts like this and this to get them removed.

Case in point: http://vimrcfu.com/snippet/95

It doesn't make sense to show the "Post your first snippet" button:

once you have already posted your first snippet (or many):

Would be cool if one could link to their .vimrc repository and even pick files from said repository to "show off".