floogen / dynamicreflections Goto Github PK

The other players are not reflected. Clients can only see himself/herself.

SMAPI 3.18.6 with Stardew Valley 1.5.6 (build 22018)

There are no NPC reflections shown at the beach during the Dance of the Moonlight Jellies.

I made a language file for German language support.
de.zip

I recently did a trial run of Dynamic Reflections and unfortunately decided it was too laggy to keep in my game, so I went to settings and turned all reflections off before the end of the day. I then experienced significantly more lag, like, slideshow-type lag, just walking around outside. I will note that I was using the river farm at the time. It was slightly better in the house.

It would be nice if there were also reflections when you are near the fountain in the town center (near the playground and the Community Center).

It seems there is a problem with sky reflections at the beach. It seems to occur only underneath the (restored) bridge for some reason where a small part remains without sky reflections (but with wavy reflections).

(Please note that for some weird reason, the problem looks even worse on the screenshot. Ingame it's just a patch underneath the bridge, while on the screenshot parts of the right shore appear to be affected as well.)

)

The green range markers when using your tools (e.g. when using the watering can or hoe) are reflected. Like the fishing UI elements, these should be hidden. This is particularly visible in the Volcano Dungeon when using the watering can on the lava to get across.

Puddles would slowly disappear based on config amount of days and be reflective.

At least in fall season (playing that now), water on the farm and on Ginger Island is purple and the lake in the desert is black.
This might be due to a combination with some other mod I have installed which still needs to be investigated.

With target location set to "Default", wavy reflections won't work at the beach. They work anywhere else, though (tested in Mountains, Town).

With sky reflections active, lava pools in the Volcano Dungeon are mostly pitch black, which destroys a lot of the atmosphere.
This ties in with my post from the Nexus forums about sky reflections being too much "in your face" in general, basically completely replacing surface textures of liquids in general (also water).

Suggestions for improvement:

• If the ceiling is just black (or any other single color), deactivate sky reflections in that area by default.
• It would be great if there was a way to make sky reflections more transparent and also add some sort of surface distortion.

When fishing with the mod active, any speech bubbles which pop up (info about fish you caught) and the power meter while casting are reflected in the water. These should not be shown since it actually looks odd.

I got this SMAPI console warning when entering the desert with v1.3.0. This might have happened when I used the Skull Cavern Elevator (mod) or before, it might also not be related to that at all.

[Dynamic Reflections] This mod failed in the Player.Warped event. Technical details:
System.Collections.Generic.KeyNotFoundException: The given key 'StardewValley.Locations.Desert' was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at DynamicReflections.Framework.Managers.PuddleManager.IsTilePuddle(GameLocation location, Int32 x, Int32 y) in C:\Users\Floogen\Documents\GitHub Repos\DynamicReflections\DynamicReflections\Framework\Managers\PuddleManager.cs:line 227
   at DynamicReflections.Framework.Managers.SkyManager.GeneratePerTile(GameLocation location) in C:\Users\Floogen\Documents\GitHub Repos\DynamicReflections\DynamicReflections\Framework\Managers\SkyManager.cs:line 63
   at DynamicReflections.Framework.Managers.SkyManager.Generate(GameLocation location, Boolean force) in C:\Users\Floogen\Documents\GitHub Repos\DynamicReflections\DynamicReflections\Framework\Managers\SkyManager.cs:line 47
   at DynamicReflections.DynamicReflections.OnWarped(Object sender, WarpedEventArgs e) in C:\Users\Floogen\Documents\GitHub Repos\DynamicReflections\DynamicReflections\DynamicReflections.cs:line 225
   at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args) in SMAPI\Framework\Events\ManagedEvent.cs:line 101

Will need to match or change how clouds currently appear in the game (i.e. the gray shadows created by overhead clouds).

It seems your pet (and potentially other NPCs, didn't test) will create a reflection in the farmhouse even though there are no reflective surfaces (happened to me when the pet lay next to the entrance near the wall, with the reflection appearing in the black area outside of the house limits).

UPDATE
Also seems to happen elsewhere, e.g. in the Church of Yoba inside of Pierre's store. So it's probably a general thing with indoor areas.

At least at the Ginger Island Docks (IslandSouth), it is not possible to activate wavy reflections for NPCs, even if IslandSouth and "Override default settings" is selected when choosing wavy reflections in the menu.

It seems with latest v1.2.0 and with wavy reflections on, NPC reflections are moving faster whenever you pass by them with your character. This does not occur when moving sideways, only if going up/down.

To describe the behavior more precisely, an example:
An NPC is standing to your lower left. You approach from above and move straight down. NPC reflection is moving faster. As soon as you reach the same level as the NPC, the wavy reflection moves normally. If you are "below" the NPC, everything is OK, it only happens if you are above him/her.

This may depend on the direction you have set up for wavy reflections, but it shouldn't happen at all, anyway. My direction is set to "South". With "North", I actually don't see any reflections at all.