flipzoommedia / processwire-aiom-all-in-one-minify Goto Github PK

Just ran into an issue where Font Awesome would still throw cross origin errors even though icons are showing..than I figured that woff2 was missing in domain sharding options in my .htaccess so it couldn't deliver and fall back to woff, so error while everything seemed to work

https://github.com/FlipZoomMedia/ProcessWire-AIOM-All-In-One-Minify/blob/AIOM%2B/doc/htaccess-and-performance-tips.html#L17

Saludos

I have a script like this:

echo "<p><strong>Label:<strong> <span>Text</span></p>"

The space between the <strong> and the <span> tags is deliberate and should be preserved as a literal space character in the paragraph.
But when the "HTML minify" option is on the space character between these tags is stripped out.
The same problem occurs if I have an <a> tag after my <strong> tag.

Some comments must not be removed from CSS for copyright/license reasons. Most other compression tools leave such comments intact once they are tagged with an explanation mark.

/*!  This comment is not removed */

I would suggest to add this feature to AIOM, I could provide a patch to the comment regex.

I was getting a connection reset error on every page load with no errors logged anywhere. It took me a while to locate the exact line, I had to keep moving an exit() call around until I found the offending piece of code.

Of course this can be solved by increasing the stack size, but so this plugin can be used in more limited environments, it might be worth not using a big regular expression, and instead opting for a different technique (seen here).

I modified AIOM to use this method, and it seems to do a better job of HTML minification as it also minifies inline styles and scripts. Though there are a couple of issues with it removing conditional comments, I think it's still worth looking into.

With the introduction of AMP technology by google, i would know if is possible to print the generated css as inline element instead of using link tag, because in AMP spec this tag aren't allowed for css but only for fonts.

Best regards

If I use on my server the same less files with AIOM+:

• checked out from GitHub
• uploaded by FTP

the final CSS are less-compiled differently.

When I add the less files to GitHub I get warning that my line-endings have been converted.

This might be due to different line endings on Windows and Linux.
Can you reproduce that error?

is there a way to keep spaces in css calc for the code to work?

You may not know this, but by installing AIOM into Processwire site, any such deployment or project effectively becomes non-free due to the usage of JSMin.php.

A description of the issue is given in this article (see section "JSMin, freedom, and the JSON License")

Theoretically any website could be taken down, should Mr. Crockford deem it "evil" - which is unlikely to happen, but still, considering JSMin is an abandoned project, #27 should be given a higher priority - i'd actually consider releasing it in a minor release rather than waiting for AIOM 4.

Passing a URL to an asset that contains a query string (i.e. ?v=2) causes the file to be rejected/ignored altogether by AIOM.

After livetime has expired only new cached files get rendered when I am logged in. Other visitors of the page will miss all styles.

Hello,

On accessing site using AIOM on windows the assets are not loaded - 404 not found.

Please if you can point me in right direction.

Thank you,
Gaurav

$_path  = (self::$directoryTraversal !== true) ? str_ireplace(array('../', './', '%2e%2e%2f', '..%2F'), '', wire('config')->paths->templates.$_file) : wire('config')->paths->templates.$_file;

This is true when the option is disabled,

self::$directoryTraversal   = ($this->directory_traversal == 1) ? true : false;

If option to traverse files is enabled (checkbox) the "self::$directoryTraversal" will be "true"

Do I miss something?

Occured on ProcessWire 2.3.8 (also tested with 2.3.5) dev using the latest (2.2.1) AIOM module.

I'm forcing HTTPS for the whole site, by setting the URL on the home template to "HTTPs only". After doing this, the creation of a new combined file fails. If I switch back to HTTP and open the site via the http:// url to generate the combined file it works. Enabling HTTPs afterwards without any changes to the CSS/JS works too.

To summarize:
HTTPS, new CSS -> AIOM fails
HTTP, new CSS -> AIOM works
HTTPS after HTTP, no changes to CSS -> AIOM works until CSS/JS Change.

I'm getting this error:
Exception: The combined css cache file could not be created. (in /home/httpd/vhosts/***/site/modules/AllInOneMinify/AllInOneMinify.module line 517)

Thanks for this module. I was just implementing here for a client, and noticed it using hard-coded 0777 permission rather than ProcessWire's $config->chmodDir and $config->chmodFile. The server I'm working with is a typical shared server, where 0777 for dirs (0666 for files) is not safe because it means other users on the server and modify the files. The same is true in many hosting environments. I was wondering if you would consider using the PW config properties I mentioned above instead, or just use PW's wireChmod('/path/to/dir/or/file'); which automatically makes them writable consistent with the PW configured settings. Assuming those PW settings are configured properly, this ensures the safety of any writable directories or files.

If file list are longer than 32 chars compile not working. If there is a file compiled until 32 chars, AIOM loading this file.
Here is my usage example :

$scripts  = array(
        'styles/bower_components/jquery/dist/jquery.min.js',
        'styles/bower_components/lazysizes/lazysizes.min.js',
        'styles/bower_components/uikit/js/uikit.min.js',
        'styles/bower_components/uikit/js/components/tooltip.min.js',
        array(
            'loadOn'  => 'template=home|reference',
            'files'   => array(
                'styles/bower_components/uikit/js/components/slideshow.min.js'
            )
        ),
        array(
            'loadOn'  => 'template=home|basic-page',
            'files'   => array(
                'styles/bower_components/uikit/js/components/slideset.min.js'
            )
        ),
        array(
            'loadOn'  => 'template=basic-page|reference',
            'files'   => array(
                'styles/bower_components/uikit/js/components/lightbox.min.js'
            )
        ),
        array(
            'loadOn'  => 'template=reference-list',
            'files'   => array(
                'styles/bower_components/uikit/js/components/grid.min.js'
            )
        ),
        array(
            'loadOn'  => 'template=reference',
            'files'   => array(
                'styles/comments.js'
            )
        ),
        'styles/init.js'
    );

if you remove md5 timestamp conversion its ok. Check MD5 -> http://php.net/md5

private static function _getCacheName($files, $prefix = 'css_', $ext = '.css') {
        // ------------------------------------------------------------------------
        // Initialize timestamp variable.
        // ------------------------------------------------------------------------
        $_timestamp = '';

        // ------------------------------------------------------------------------
        // Combine all timestamps to one string.
        // ------------------------------------------------------------------------
        foreach ($files as $file) {
            $_timestamp .= $file['last_modified'];
        }

        // ------------------------------------------------------------------------
        // Create a unique MD5 file name with the specified prefix.
        // ------------------------------------------------------------------------
        return (self::$developmentMode !== true) ? $prefix.md5($_timestamp).$ext : $prefix.md5($_timestamp).'_dev'.$ext;
    }

SASS:
$custom-checkbox-indicator-icon-checked: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' width='8' height='8' viewBox='0 0 8 8'><path fill='#{$custom-control-indicator-checked-color}' d='M6.564.75l-3.59 3.612-1.538-1.55L0 4.26l2.974 2.99L8 2.193z'/></svg>") !default;

MINIFIED (Spaces removed - Not Working):
url("data:image/svg+xml,%3csvgxmlns='http://www.w3.org/2000/svg'width='8'height='8'viewBox='0088'%3e%3cpathfill='%23fff'd='M6.564.75l-3.593.612-1.538-1.55L04.26l2.9742.99L82.193z'/%3e%3c/svg%3e")

EXPCETED (Works):
url("data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' width='8' height='8' viewBox='0 0 8 8'%3e%3cpath fill='%23fff' d='M6.564.75l-3.59 3.612-1.538-1.55L0 4.26l2.974 2.99L8 2.193z'/%3e%3c/svg%3e")

A issue with the path of the images into the css file when pw is installed in a subdirectory, example:

the correct file path output without AIOM+

http://localhost/mysite/site/templates/images/image.jpg

file path output with AIOM+ enable

http://localhost/site/templates/images/image.jpg

this generate 404 error, file not found.

I tried to fix changing the RewriteBase in .htaccess enabling my localhost subdirectory

RewriteBase /mysite/

but the same error still happens if I turn off the AIOM + and use the url from the css file works without any inconvenience..

Hi David,

This is a great module but I have a small issue when using it. Iif I link to a Google webfont in my CSS (via @import) it doesn't display at all.

Regards
Marty

AIOM seems to conclict with ProcessWire Core's cache. In AIOM I have set Lifetime to 2419200 for my CSS and JS files. In ProcessWire, I cache the pages -- here: Templates > Go to the Cache tab. and set Cache Time to 86400 (24 hours).

The reason for this issue is that AIOM updates the file name for the cached CSS and JS files while ProcessWire's Page Render cache does not update the file names simultaneusly.

File names cached by ProcessWire's Page Render Cache (in my case, these files do not exist to end-users / 404):

For instance, these file names were shown to me because I was logged in (valid files / 200):

<link rel="stylesheet" href="/site/assets/aiom/css_e4c680d6b59866248e0dc0a3317324a0.css">
<script src="/site/assets/aiom/js_cde06f61b83de6205615a30c87616efd.js"></script>

... and these were the file names presented to the end-user (the files did not exist / 404):

<link rel="stylesheet" href="/site/assets/aiom/css_xxxxxxxxxxxxxxxx999999999999.css">
<script src="/site/assets/aiom/js_xxxxxxxxxxxxxxxx999999999991.js"></script>

My workaround was to copy the contents of the AIOM files into static files outside the AIOM folder -- since this will allow cached PW-files to always point at the correct CSS/JS file. Example:

<link rel="stylesheet" href="/site/assets/style.css">
<script src="/site/assets/js_top.js"></script>
<script src="/site/assets/js_bottom.js"></script>

Hi
I got two problems that all have to do with the Processwire Template Cache when using AIOM.

1) First of the ClearCacheFromBackend issue:
Following initial situation:

• I have the template cache enabled and pages are in the cache
• I have AIOM Files in the cache
• Now Goto AIOM Config Screen and click "Empty Cache" (/module/edit?name=AllInOneMinify).
• Then Goto to the Frontend (with a non logged in browser) on a page where TemplateCache should be active.
• The CSS and JS Files are not there anymore and breaks the layout.

In the AllInOneMinify::ClearCacheFromBackend Funtion there is no direct removal of the cache files. On cached Version in Frontend AIOM never reaches the point where the CacheFiles would be deleted, wich is
here for JS and here for CSS:

If i am adding this code in ClearCacheFromBackend after self::_clearCache(true); here

$pageRender = wire('modules')->PageRender;
if($pageRender) {
   CacheFile::removeAll(wire('config')->paths->cache.PageRender::cacheDirName."/");
}

this issue is removed.
Can anyone confirm this?

2) The second Problem
has a direct relation to this, so I post it here.
When using AIOM in PW3 I think the class_exists function used for checking if PageRender exists never returns true.

• class_exists in JS
• class_exists in CSS

This has todo with Namespaces in PW3 I guess (see php.net comment). Also the compiled FileCompiler Version does not add anything to the class_exists call. However, I am wondering it this if statement with class_exists is needed anyway. Beacause PageRender cannot be uninstalled, it should always be there. Perhaps I´m missing something here? Another way of checking without class_exists would be the way I do it in the Example above.

I hope that someone can confirm this issues and write back. I had two sites broken in the last week. I don´t know exactly what happened that AIOM FileCache got cleared in the backend, but with this simple solution it should not happen anymore...

I can make a pull request if this helps...
thanks

This error happend after install:

Error: Exception: RecursiveDirectoryIterator::__construct(/home/myserver/public_html/mysite/site/assets/aiom/) [recursivedirectoryiterator.--construct]: failed to open dir: Permission denied (in /home/myserver/public_html/mysite/site/modules/AllInOneMinify/AllInOneMinify.module line 408)

This error message was shown because you are logged in as a Superuser. Error has been logged.

I have this error when debug mode is true and the module not work...

Strict Standards: Non-static method AllInOneMinify::JS() should not be called statically, assuming $this from incompatible context in /home/myserver/public_html/mysite/site/templates/main.php on line 138

Strict Standards: Non-static method AllInOneMinify::_fileArray() should not be called statically, assuming $this from incompatible context in /home/myserver/public_html/myserver/public_html/mysite/site/modules/AllInOneMinify/AllInOneMinify.module on line 231

Strict Standards: Non-static method AllInOneMinify::_getCacheName() should not be called statically, assuming $this from incompatible context in /home/myserver/public_html/demos/hotelkahve/site/modules/AllInOneMinify/AllInOneMinify.module on line 232

Notice: Undefined variable: _timestamp in /home/myserver/public_html/demos/hotelkahve/site/modules/AllInOneMinify/AllInOneMinify.module on line 448

/mysite/site/assets/aiom/js_27a4aa3dfbfbe40ad50d2f177f91e918.js">

I find it strange how the module is built and the way it is setup I can't for example overwrite a config var on runtime... cause all is static?

I.e: stuff like
$modules->AllInOneMinify->development_mode = true;

Or why is the module autoload? 'autoload' => true,

It means it load even if there's no call for any of AIOM in templates. A on demand loading would be much better.

$aiom = $modules->AllInOneMinify;

echo $aiom->CSS();

noindex, nofollow should can be set also on every single page, instead of globally. For example: I want to set noindex,nofollow only on the pages "Imprint" and "Privacy".

the latest version (on PW 5.19) adds the domain name twice in the path of images.
e.g. http://site.com/sites/www.site.com/site/templates/img/image.png

When turning debug mode on, the stylesheet does not get parsed correctly and gives this error in the page's head:

"Division by zero in .../site/modules/AllInOneMinify/lib/Less/Less.php on line 2896"

When debug mode is off in ProcessWire, things run just fine. Please let me know what other information I can provide.

Upon using AIOM in a PHP 7.1 environment, I am now seeing several warnings and notices appearing.

Warning: A non-numeric value encountered in AllInOneMinify.module on line 713

Upon further inspection, the variable $_timestamp is initialised as '' rather than 0. Therefore the new notices that PHP issues when arithmetic is performed on non numeric values pop up.

The other error I saw is:

Notice: A non well formed numeric value encountered in cssmin.php on line 769

Upon further inspection, I can see that the variable $size is an integer in the form of a string, and is sometimes suffixed with a unit. That unit is not removed before $size is implicitly casted to an integer during the arithmetic seen on that line.

None of issues actually cause any real problems, it's just nice knowing that there are no errors being issued whatsoever.

hi i just install new ssl to my site and sub domain, and then i activate domain sharding option change url to https subdomain and then i clear all the template cache, module cache, compile files but https domain sharding url not printing. the module only print http domain sharding url not https, how can i solve this.

The seems to be a bug with the CSS compression.

#nav :hover{}

becomes when compressed:

 #nav:hover{}

The blank should not be removed as it is a separator between a parent and a child element and removing it changes the cascade!

The the first rule identifies a child element of a #nav element which is hovered over like the anchor link in this HTML snippet:

<div id="nav"><a href="/">I am a hovering child element</a><div>  

and the latter identifies just the #nav element itself which is hovered over like:

<div id="nav"> I am a hovering parent element. My children don't matter. <div>  

As a consequence this bug breaks CSS based menus.

I have inline scripts for banners, they are not working when using HTML Minify option.

BTW are you still maintaining this module? It's the most liked on modules.processwire.com, but haven't heard anything since a long time.

AOIM is generating CSS and js files but they're coming up blank (except for a comment if I turn on dev mode).

The site is running PW 2.4 and I'm using AOIM 3.1.3.

Files are in a folder outside my templates directory but I've turned on directory traversal.

I've also got HTML minify turned on but it's not minifying.

Are there any plans to add SCSS support to AIOM?
I saw that Bootstrap 4 will be using Sass instead of Less.

I think it would be a great feature to add SASS Support. There is already a PHP SASS Compiler out there... http://leafo.net/scssphp/

anyway, thanks for this great module!

on line 751 You should not replace "../" dir to "". It had different meaning with "./"

// Fix Error, you should not replace "../" to ""
        //$_path  = str_ireplace(array('../', './', '%2e%2e%2f', '..%2F'), '', (wire('config')->paths->templates.$_file));
        $_path  = wire('config')->paths->templates.$_file;

I'd love to see an option to switch the order of operations so that watched .less files are concatenated first, then compiled. It's easier to maintain larger projects if you can just add a new library file in the correct position and not have to worry about @importing it in every file that depends on it.

At times it's advantageous to group code into multiple packages, for example when one page of a site contains a lot of extra code that is only needed on that one page. Is it possible to use AIOM to produce a separate package for each of these?

Hi there,
as my Processwire installation is in a subdirectory and under a subdomain, I came across a problem where all URIs in the minified CSS file were wrong. The problem is that my $_SERVER['DOCUMENT_ROOT'] differs from the document root of my processwire.

docRoot of PW: /home/htdocs/processwire
$_SERVER['DOCUMENT_ROOT']: /home/htdocs

URIs in CSS as they are /processwire/site/templates/styles/images/image.jpg
URIs in CSS as they should be /site/templates/styles/images/image.jpg

The Rewrite-Function in site/modules/AllInOneMinify/lib/UriRewriter.php uses the docRoot as third parameter. But in line 573 of AllInOneMinify.module there is no third parameter given, resulting in the Rewrite-Function to use $_SERVER['DOCUMENT_ROOT'] as value.

So after changing line 573 of AllInOneMinify.module from

$_css_src = (!empty($_css_src)) ? Minify_CSS_UriRewriter::rewrite($_css_src, dirname($stylesheet['absolute_path'])) : $_css_src;

to

$_css_src = (!empty($_css_src)) ? Minify_CSS_UriRewriter::rewrite($_css_src, dirname($stylesheet['absolute_path']),wire('config')->paths->root) : $_css_src;

everything worked as expected. :-)

As always, thank you very much for your work with this module, I am using it in every project I'm working on. would be interesting to have the option to upload each file conditionally, eg:

where [id] is the ID of the page, without the [id] would load on all pages.

(Just a small, not so important issue:)

Using the text-align:justify CSS grid doesn't work in combination with the minified HTML. The grid will shift a little bit left. Maybe some invisible characters are removed?

I can solve the problem by deactivating the HTML minify output.

More info:
http://justifygrid.com/

For Developer Mode would be nice
suggest for line 604

if(self::$developmentMode === true) $options = array( 'sourceMap' => true );
$_less_parser   = new Less_Parser($options);

In the CSSMin php
// ------------------------------------------------------------------------
// Remove empty blocks.
// ------------------------------------------------------------------------
// $_source = preg_replace('/}[^\/}]+{}/', '}', $_source);

I had to comment out because I like to have some media query in some css empty while developing. The removing of the empty brackets lead to unexpected results with "open" media queries.

It would be nice to be able to use modules with styles/scripts and absolute paths from /site/.

I've tested something like this and seems to be working fine:

private static function _getFileInfoArray($_file, $extension) {

        if(strpos($_file, "/site") === 0){
            $_path = wire('config')->paths->root. ltrim($_file,"/");
        } else {
            // ------------------------------------------------------------------------
            // Filter Directory Traversal (default: yes)
            // ------------------------------------------------------------------------
            $_path  = (self::$directoryTraversal !== true) ? str_ireplace(array('../', './', '%2e%2e%2f', '..%2F'), '', wire('config')->paths->templates.$_file) : wire('config')->paths->templates.$_file;
        }

....

The function _getCacheName uses the last_modified timestamp to generate a unique filename.

In my case, I use the same LESS files for 2 different page templates, except for 1 LESS file (which depends on the page template used). So I should get a different CSS file in this template.
But unfortunately the 2 LESS files that differ have exactly the same last_modified timestamp, so the same filename is generated for the CSS file. This results in incorrect classes in the CSS file included in 1 of the pages.

From the JSMin page:

This project is unmaintained. I stopped using it years ago. You shouldn't use it. You shouldn't use any version of JSMin. There are much better tools available now.

Consider replacing it with JShrink :-)

When feeding a less file to AIOM that includes an @import for another .less file in the same directory, less compilation fails, producing the following ending output in the generated css file:

#_____LESS_____ERROR_____REPORT_____ {content:"File `/site/templates/styles/phone.less` not found. in anonymous-file-0.less"}

The problem only occurs on the live server, which is a shared hosting environment with a virtual host, whilst my local environment does not employ a virtual host. The same live environment also suffers from bug #38

Both problems occur whenever DOCUMENT_ROOT (which is used by Minify_CSS_UriRewriter::rewrite) is different from wire('config')->paths->root (which always gives the accurate position of files).

Related issues:

• #38
• oyejorge/less.php#221

I have now fixed and tested both issues locally and will send a PR shortly.

If an array of filenames are passed, and all files have the same modified timestamp on separate pages a collision will occur and the wrong file is served for subsequent pages.

eg: Page 1 - array('file1.js','file2.js');
Page 2 - array('file1.js','file3.js');

Each file has the same timestamp (ie; rsync or similar copy operation).

Simple fix:
$_timestamp = ($_timestamp + $file['last_modified'] . basename($file['absolute_path']));

When PW is not running in the domain's root folder, but in a subfolder (ie. /dev) the minified relative css image location points to the root instead of the subfolder.

Example:

• PW is running from http://mydomain.com/dev/project
• Images are in http://mydomain.com/dev/project/site/templates/img
• Css is in http://mydomain.com/dev/project/site/templates/css
• Css uses: .mystyle { background: url(../img/myimage.png); }

AIOM 3.2.1 tries to find the images in http://mydomain.com/site/templates/img

With PHP 7.3.0 (Windows), AllInOneMinify 3.2.3, ProcessWire 3.0.123, I get the following Continue Targeting Switch Warning (path parts snipped):

Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9387
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9395
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9400
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9406
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9416
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9419
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9439
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9444
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9465
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9472

I have not tried the fork mentioned in #65 , maybe this has been fixed there too.

If a large LESS file is split by the parser, the following error occurs:

"Error: Class 'Less_Exception_Parser' not found (line 8795 of /site/modules/AllInOneMinify/lib/Less/Less.php)"

Issue found and submited by Ryan Pierce. Thanks.