flexmonkey / filterpedia Goto Github PK

There are a few places where MTLCreateSystemDefaultDevice is being force unwrapped and it causes crashes on devices that don't support Metal.

I have been looking for a good excuse to get an iPad Pro though... :)

I was looking through all the filters, when a crash happened in Triangle Kaleidoscope.
Interestingly, it didn't happen again on next launch. Then I noticed that some of the filters above Triangle Kaleidoscope now showed different output. Somehow some of them didn't show output at all before, but I don't remember which (I think the [...] Tile filters). I can also not reproduce this.

2016-02-05 19:37:32.750 Filterpedia[1538:582807] -[CIVector floatValue]: unrecognized selector sent to instance 0x14c65fd30
2016-02-05 19:37:32.751 Filterpedia[1538:582807] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[CIVector floatValue]: unrecognized selector sent to instance 0x14c65fd30'

Any chance of publishing this for Mac OS too?

I'd LOVE to help - but I'm struggling myself with applying CIFilters onto live camera input on Mac OS, and I seem to miss some of the basics there.

Otherwise - I'm very experienced in Application design and development. Please let me know if you're interested.

Many of the Filters Including EightBit, CRT, Bayer Dither, Lens Flare, Lens Correction etc. based on CIKernel are crashing due to new changes.

ERROR: parameter has unexpected type 'vec4' (should be a sampler type) vec2 uv = samplerCoord(image);

This seems to be a common error message among most crashing filters. please check.

There are over 20-30 compile errors on the swift-3 branch.

Looks like a great library, but which software license is this released under? I don't see a license file in the repo.

In my tests, your MetalKuwaharaFilter is actually 50% slower then KuwaharaFilter however here Simon mentions Metal is supposed to be 50% faster.

Any idea why it is like that?

I cannot build the master or Swift 3.0 branch on Xcode 8.1. Please let me know if you would like me to fix the issues and submit a PR.

Running in iPad Air 2 iOS 9.3 simulator in Xcode 7.3 on OS X 10.11.4:

2016-04-13 20:25:17.738 Filterpedia[5960:487581] __64+[CIFilter(CIFilterRegistryPrivate) filterWithName:setDefaults:]_block_invoke520 [constructor filterWithName:AdvancedMonochrome] returned an object of class Filterpedia.AdvancedMonochrome.

Looks like CIFilter doesn't like modules in this instance. I had a quick look around the code but couldn't figure out why.

some function Attributes that override from class CIFilter must change from [String: AnyObject] to [String: Any]

You've added so many great filters that I sometimes struggle to find a specific one. (Take that as a compliment!)

Would you be interested in adding a search function to the filter list? I've been considering making a pull request, but wanted to check that you'd be interested in merging it, and that you're not already working on it.

I am implementing feature with red, orange, yellow, green, aqua, blue, purple color selection and one UISlider. I am not understanding how to use MultiBandHSV with UISlider properly.

Thank you.

I don't want to presume that choosing GPL was not intentional, but are you aware that it does not allow for commercial use (distribution) unless the app you're using it in is also open-source (ref: http://softwareengineering.stackexchange.com/questions/47032/can-i-use-gpl-software-in-a-commercial-application)? Is there any chance you'd be willing to license it under something more permissive like MIT or BSD?

For us folks without iPads, it would be great to use filterpedia in the simulator. Looks like this is related to MetalKit not being supported in the simulator.

http://stackoverflow.com/questions/24086194/how-do-you-import-metal-in-swift

I bring this up because it may deter some people from buying your book, and I want you to sell a lot of copies of your book :-)

Hello, I tried to convert HistogramDisplay to Swift 3 but I have a problem with this lines of code:

 let histogram = UnsafeMutablePointer<UnsafeMutablePointer<vImagePixelCount>>(mutating: rgba)       
 vImageHistogramCalculation_ARGB8888(&inBuffer, histogram, UInt32(kvImageNoFlags))

the vImageHistogramCalculation_ARGB8888 method is still same as in Swift 2.3 but I can't properly initialized an optional UnsafeMutablePointer<UnsafeMutablePointer> method. Some ideas? :)

I received the error:

: Cannot invoke initializer for type 'UnsafeMutablePointer<UnsafeMutablePointer?>' with an argument list of type '(mutating: [UnsafeMutablePointer])'

Hi,

Very very good job :)

Is it possible to use VectorSlider in Objective C project?