Giter Club home page Giter Club logo

Comments (2)

dcconner avatar dcconner commented on June 26, 2024

I believe the bug is real and your change is necessary, but not sufficient. You are getting around the if not isinstance but will fail that that becomes true as in the case of reloaded behavior. I don't have time to test and verify the fix until later this week. If you want the fame that comes with an accepted PR we'll need to fix the srv_type.__name__ lines as well, and come up with a simple test case. Otherwise, I'll look into testing and fixing this weekend.

from flexbe_behavior_engine.

dcconner avatar dcconner commented on June 26, 2024

@joshjowen I have issued PR #2 to fix this issue. Thanks for catching this bug and reporting. I have also done some clean up of the wait_duration and allow connection when the service is not present. (I have requested review prior to merging as this includes some other changes.) For testing, I created a simple behavior using the ROS Turtlesim demo. You may check it out here It needs some clean up before I release on FlexBE GitHub, so comments are welcome. It might be worth looking at because I demonstrate setting up both blocking and non-blocking service calls . Your example above calls the proxy setup and makes service call in on_enter in a blocking manner. Normally we want to avoid potential long duration calls in our states. I appreciate any feedback on the new ROS 2 version of FlexBE, so keep filing issues as needed.

from flexbe_behavior_engine.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.