Comments (2)
I believe the bug is real and your change is necessary, but not sufficient. You are getting around the if not isinstance
but will fail that that becomes true as in the case of reloaded behavior. I don't have time to test and verify the fix until later this week. If you want the fame that comes with an accepted PR we'll need to fix the srv_type.__name__
lines as well, and come up with a simple test case. Otherwise, I'll look into testing and fixing this weekend.
from flexbe_behavior_engine.
@joshjowen I have issued PR #2 to fix this issue. Thanks for catching this bug and reporting. I have also done some clean up of the wait_duration and allow connection when the service is not present. (I have requested review prior to merging as this includes some other changes.) For testing, I created a simple behavior using the ROS Turtlesim demo. You may check it out here It needs some clean up before I release on FlexBE GitHub, so comments are welcome. It might be worth looking at because I demonstrate setting up both blocking and non-blocking service calls . Your example above calls the proxy setup and makes service call in on_enter in a blocking manner. Normally we want to avoid potential long duration calls in our states. I appreciate any feedback on the new ROS 2 version of FlexBE, so keep filing issues as needed.
from flexbe_behavior_engine.
Related Issues (12)
- only sleep after state returned None outcome (ROS 1)? HOT 2
- python-six dependency blocking Humble release HOT 1
- AttributeError: module 'rclpy.signals' has no attribute 'SignalHandlerOptions' HOT 3
- flexbe_mirror setup.py lists unnecessary console scripts HOT 3
- Version change and UI update for ConcurrencyContainer Handling HOT 1
- ActionClientProxy can't query goal status HOT 7
- ROS-Galactic HOT 2
- some ROS 2 states are still using ROS 1 actions HOT 2
- FlexibleCalculationState does not accept correct lambda expression HOT 1
- ROS 2 subscriber state msg_type attribute HOT 1
- Publish State Path to ROS Topic when entering a State HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flexbe_behavior_engine.