Giter Club home page Giter Club logo

org.flatpak.builder's People

Contributors

alexlarsson avatar barthalion avatar erick555 avatar flathubbot avatar gasinvein avatar guihkx avatar hfiguiere avatar hughsie avatar matyat avatar mwleeds avatar nanonyme avatar nedrichards avatar starnight avatar tingping avatar

Stargazers

avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

matyat nanonyme mwleeds doomsdayrs starnight guihkx

org.flatpak.builder's Issues

`rename-desktop-file` breaks builds

I'm using rename-desktop-file: mudlet.desktop per flathub builder documentation but the process is faulty:

Removing files/bin
Renaming mudlet.desktop to org.mudlet.mudlet.desktop
Error: Error moving file /home/vadi/Programs/Mudlet/CI/.flatpak-builder/rofiles/rofiles-Ud5nW9/files/share/applications/mudlet.desktop: No such file or directory

It renames the file but then proceeds to use the original, pre-rename filename.

Without the renaming, it works fine:

Removing files/bin
Committing stage cleanup to cache
Finishing app

This is using flatpak-builder 1.3.1.

LFS support broke

Description

At some point within the last month, git-lfs support broke itself again.

Expected Behavior

git-lfs properly pulls objects.

Actual behavior

flatpak run org.flatpak.Builder build --force-clean build *.yaml log.txt

Additional Context

I tested with flatpak-builder as installed via rpm, version 1.2.3 and it worked fine.

image

Experimenting with the flatpak version of the builder, I discovered that while the builder does use the same version of the flatpak-builder, it has something preventing the proper pull via git-lfs.

I experimented with the flatpak versions of builder, from the current version to all the way back to 567fcc0 .

This is my limit of knowledge currently.

No Packaged Documentation

When using the host flatpak-builder the man pages are installed along side the executable. However in the flatpak'ed version there is no documentation installed at all.

I know that I can access the same docs through http://docs.flatpak.org/en/latest/flatpak-builder-command-reference.html, but shipping doc with executables definitely has advantages:

  • I know that the docs I'm reading pertain to the exact version of software I'm using.
  • No reliance on external networks, so in the case that docs.flatpak.org is not available (for example our builders are on a isolated network) the documentation is still in reach.

The minimum could be to add "config-opts": ["--enable-documentation"] to the flatpak-builder module. So the documentation is available through:

$ flatpak run --command=bash org.flatpak.Builder
bash-4.3$ man flatpak-builder

Or perhaps create a org.flatpak.Builder.Docs extension?

I'm not entire sure what the recommended method is for shipping docs in a flatpak.

Breakage with screenshot and --mirror-screenshots-url

On many package, screenshots are on github, and the mirroring process end up with a 0 bytes file. This make many build to fail. Examples:

flathub/com.nitrokey.nitrokey-app#2
(first build worked, rebuilt it later as the linter was deployed and it failed)

I traced it back, that last build I got to work was the last build with 21.08 runtime (commit dec4df9)

The next one I could get to build is at commit ee10f9e and fails.

In term of repo:

    Commit: 10ff128bf9723a3d0b56d1adfdea7680e66c3ed4f1cd46fb8fbddb09a4aaa076
   Subject: Build ostree with curl support (81531075)
      Date: 2022-09-02 11:53:30 +0000

produces:

com.nitrokey.nitrokey-app:         Failed to download https://github.com/Nitrokey/nitrokey-app/raw/master/images/screenshot-main-window.png: Image file “/home/hub/source/flathub/com.nitrokey.nitrokey-app/.flatpak-builder/screenshots-cache/com.nitrokey.nitrokey-app-screenshot-main-window.png” contains no data

    Commit: 01c6c161ee2010d52472cb99bd277de082e4f5116024964621f524548e7fffb8
   Subject: Don't update appstreamcli (dec4df9b)
      Date: 2022-06-20 07:19:20 +0000

Produces

com.nitrokey.nitrokey-app:         Downloading https://github.com/Nitrokey/nitrokey-app/raw/master/images/screenshot-main-window.png
com.nitrokey.nitrokey-app:         Saved to cache /home/hub/source/flathub/com.nitrokey.nitrokey-app/.flatpak-builder/screenshots-cache/com.nitrokey.nitrokey-app-screenshot-main-window.png

Edit: I forgot to mention this happen when calling flatpak-builder with --mirror-screenshots-url which is what fails.

Missing YAML support

Apparently this flatpak is not built against YAML so it doesn't support large amount of Flathub apps.

--run does not work

When I try to use the --run, I get the following (using host flatpak-builder works fine):

$ LANG=C org.flatpak.Builder --run build-local/ io.github.gillesdegottex.FMIT.local.json fmit
error: Failed to execute child process ?/app/libexec/flatpak-bwrap? (No such file or directory)

Is this expected/intended? Thanks!

flatpak-spawn: Unable to read struct signalfd_siginfo: Bad file descriptor

Linux distribution and version

Arch Linux

Flatpak version

Flatpak 1.11.2

Description of the problem

While building flatpaks using flatpak-builder flatpak there are a lot (hundreds) of warnings related to flatpak-spawn printed in output at various stages:

** (flatpak-spawn:29): WARNING **: 11:28:11.436: Unable to read struct signalfd_siginfo: Bad file descriptor
...
** (flatpak-spawn:59): WARNING **: 11:37:10.183: Unable to read struct signalfd_siginfo: Bad file descriptor
...
** (flatpak-spawn:78): WARNING **: 11:45:53.263: Unable to read struct signalfd_siginfo: Bad file descriptor
...
** (flatpak-spawn:101): WARNING **: 11:45:59.814: Unable to read struct signalfd_siginfo: Bad file descriptor

Beside of the above the build succeeds.

Steps to reproduce

Build flatpak using flatpak-builder flatpak, i.e
flatpak run org.flatpak.Builder build org.flatpak.Builder.yml

This is copy of issue reported at flatpak/flatpak-xdg-utils#55 . According to feedback there is a bug in fusermount-wrapper.sh :

Actually, I think this might be a bug in https://github.com/flathub/org.flatpak.Builder/blob/master/fusermount-wrapper.sh. It's blindly forwarding fd 3 to the host, even if fd 3 is not actually open. If fd 3 is the signalfd that flatpak-spawn uses internally, then it'll get closed, leading to failure.

appstream-util fails to handle URLs that respond with 301 redirect

flatpak run --command=appstream-util org.flatpak.Builder validate fails on correct URLs that respond with 301 redirect to requested resource:

(appstream-util:2314270): As-DEBUG: 18:24:58.861: run appstream-util: validate
com.agatanawrot.karambola.metainfo.xml: (appstream-util:2314270): As-DEBUG: 18:24:58.866: checking https://holypangolin.com/stuff/karambola/screenshots/1.jpg
(appstream-util:2314270): As-DEBUG: 18:24:59.114: Adding file-invalid '<screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/1.jpg]'
(appstream-util:2314270): As-DEBUG: 18:24:59.114: checking https://holypangolin.com/stuff/karambola/screenshots/2.jpg
(appstream-util:2314270): As-DEBUG: 18:24:59.144: Adding file-invalid '<screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/2.jpg]'
(appstream-util:2314270): As-DEBUG: 18:24:59.144: checking https://holypangolin.com/stuff/karambola/screenshots/3.jpg
(appstream-util:2314270): As-DEBUG: 18:24:59.171: Adding file-invalid '<screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/3.jpg]'
(appstream-util:2314270): As-DEBUG: 18:24:59.171: checking https://holypangolin.com/stuff/karambola/screenshots/4.jpg
(appstream-util:2314270): As-DEBUG: 18:24:59.200: Adding file-invalid '<screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/4.jpg]'
(appstream-util:2314270): As-DEBUG: 18:24:59.200: checking https://holypangolin.com/stuff/karambola/screenshots/5.jpg
(appstream-util:2314270): As-DEBUG: 18:24:59.228: Adding file-invalid '<screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/5.jpg]'
(appstream-util:2314270): As-DEBUG: 18:24:59.228: checking https://holypangolin.com/stuff/karambola/screenshots/6.jpg
(appstream-util:2314270): As-DEBUG: 18:24:59.256: Adding file-invalid '<screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/6.jpg]'
FAILED:
• file-invalid          : <screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/1.jpg]
• file-invalid          : <screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/2.jpg]
• file-invalid          : <screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/3.jpg]
• file-invalid          : <screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/4.jpg]
• file-invalid          : <screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/5.jpg]
• file-invalid          : <screenshot> failed to load [https://holypangolin.com/stuff/karambola/screenshots/6.jpg]
Validation of files failed

This leads to failed builds on Flathub.

In above example, https://holypangolin.com/stuff/karambola/screenshots/1.jpg redirects to https://dosowisko.net/holypangolin/karambola/screenshots/1.jpg.

The same file works fine with both flatpak run org.freedesktop.appstream-glib validate and appstreamcli validate.

Can't build org.flatpak.Builder with org.flatpak.Builder

Works fine with native, I got this with org.flatpak.Builder 0.99.3 (Flatpak 1.0.0)
Dependency Sdk: org.freedesktop.Sdk 1.6
FB: Running 'flatpak --system info org.freedesktop.Sdk/x86_64/1.6 --show-commit' on host
FB: host_command_exited_cb 11240 0

FB: Running 'flatpak --system update --subpath= -y org.freedesktop.Sdk/x86_64/1.6' on host
Looking for updates...
FB: host_command_exited_cb 11243 0

Dependency Runtime: org.freedesktop.Sdk 1.6
FB: Running 'flatpak --system info org.freedesktop.Sdk/x86_64/1.6 --show-commit' on host
FB: host_command_exited_cb 11262 0

FB: Running 'flatpak --system update --subpath= -y org.freedesktop.Sdk/x86_64/1.6' on host
Looking for updates...
FB: host_command_exited_cb 11265 0

FB: Running 'flatpak info --arch=x86_64 --show-commit org.freedesktop.Sdk 1.6' on host
FB: host_command_exited_cb 11285 0

FB: Running 'flatpak info --arch=x86_64 org.freedesktop.Sdk 1.6' on host
FB: host_command_exited_cb 11288 0

FB: Running 'flatpak info --arch=x86_64 --show-commit org.freedesktop.Sdk 1.6' on host
FB: host_command_exited_cb 11291 0

Downloading sources
FB: Running: git --version
FB: Git version: 2.9.3.0
FB: Running: git cat-file -e c2266e2bce9d8f72e3f705e04719c7d9a924fd87
FB: Running: git ls-remote origin
FB: Running: git config transfer.fsckObjects 1
Fetching full git repo https://github.com/flatpak/flatpak-xdg-utils.git
FB: Running: git fetch -f -p --no-recurse-submodules --tags origin ':'
FB: Running: git rev-parse c2266e2bce9d8f72e3f705e04719c7d9a924fd87
FB: Running: git rev-parse --verify --quiet c2266e2bce9d8f72e3f705e04719c7d9a924fd87:.gitmodules
Initializing build dir
FB: Running 'flatpak build-init --arch=x86_64 /home/user/git/org.flatpak.Builder/build-dir org.flatpak.Builder org.freedesktop.Sdk org.freedesktop.Sdk 1.6'
error: open(O_TMPFILE): Permission denied
Error: Child process exited with code 1

Get rid of Python 2

Python 2 was EOL'd last April. Let's try to remove it from this app completely.

git-lfs missing

Veloren fails to build due:

git-lfs filter-process: line 1: git-lfs: command not found

Issue appeared first time 20 days ago (2021-12-31). I wonder could this been related to migration on org.flatpak.Builder instead of old flatpak-builder?

Can't rebuild - 404 for subversion tarball and incorrect sha256sum for diffstat 

Downloading sources
Downloading http://apache.mirrors.spacedump.net//apr/apr-1.6.3.tar.bz2
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  834k  100  834k    0     0   835k      0 --:--:-- --:--:-- --:--:--  988k
Downloading http://apache.mirrors.spacedump.net//apr/apr-util-1.6.1.tar.bz2
100  418k  100  418k    0     0  1808k      0 --:--:-- --:--:-- --:--:-- 1808k
Downloading https://github.com/JuliaLang/utf8proc/archive/v2.1.1.tar.gz
100   128    0   128    0     0    135      0 --:--:-- --:--:-- --:--:--   234
100   129    0   129    0     0    118      0 --:--:--  0:00:01 --:--:--   118
100  148k    0  148k    0     0  73075      0 --:--:--  0:00:02 --:--:--  186k
Downloading http://apache.mirrors.spacedump.net/subversion/subversion-1.10.0.tar.bz2
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
Failed to download sources: module subversion: The requested URL returned error: 404 Not Found

$ curl -O http://invisible-island.net/datafiles/release/diffstat.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  257k  100  257k    0     0   655k      0 --:--:-- --:--:-- --:--:--  655k
$ sha256sum diffstat.tar.gz 
7f09183644ed77a156b15346bbad4e89c93543e140add9dab18747e30522591f  diffstat.tar.gz

...
                 {
                     "type": "archive",
                     "url": "http://invisible-island.net/datafiles/release/diffstat.tar.gz",
                     "sha256": "25359e0c27183f997b36c9202583b5dc2df390c20e22a92606af4bf7856a55ee"
                 }
...

I could just update it to http://apache.mirrors.spacedump.net/subversion/subversion-1.10.2.tar.bz2 and update the diffstat checksum, but having stable mirrors is probably a prerequisite for build reproducibility.

Fails to rename desktop file when used with Flatpak 1.10.x

I tried building an app using org.flatpak.Builder 1.2.2 on an Endless OS system with Flatpak 1.10.7 (matching Debian Bullseye). It fails when renaming the desktop file in an unexpected way.

Given the following manifest:

{
    "app-id": "uk.me.wjt.FlatpakBuilderTest",
    "runtime": "org.freedesktop.Platform",
    "runtime-version": "21.08",
    "sdk": "org.freedesktop.Sdk",
    "command": "/bin/true",
    "rename-desktop-file": "test.desktop",
    "modules": [
        {
            "name": "test",
            "buildsystem": "simple",
            "sources": [
                {
                    "type": "file",
                    "path": "test.desktop"
                }
            ],
            "build-commands": [
                "install -D -t /app/share/applications test.desktop"
            ]
        }
    ]
}

and the following test.desktop:

[Desktop Entry]
Name=Test
Exec=true

Then with flatpak-builder 1.0.12 (from Debian Bullseye) the build succeeds, but with org.flatpak.Builder 1.2.2 it fails as follows:

Emptying app dir '_app'
Downloading sources
Starting build of uk.me.wjt.FlatpakBuilderTest
Cache hit for test, skipping build
Cache miss, checking out last cache hit
Cleaning up
Renaming test.desktop to uk.me.wjt.FlatpakBuilderTest.desktop
Error: Error moving file /sysroot/home/wjt/tmp/fbtest/.flatpak-builder/rofiles/rofiles-lZv3CH/files/share/applications/test.desktop: No such file or directory

flatpak Builder fails to find flatpak-validate-icon

Linux distribution and version

$ cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux bullseye/sid"
NAME="Debian GNU/Linux"
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Flatpak-builder version

$ flatpak info org.flatpak.Builder 
          ID: org.flatpak.Builder
         Ref: app/org.flatpak.Builder/x86_64/stable
        Arch: x86_64
      Branch: stable
      Origin: flathub
  Collection: org.flathub.Stable
Installation: user
   Installed: 51.3 MB
     Runtime: org.freedesktop.Sdk/x86_64/18.08
         Sdk: org.freedesktop.Sdk/x86_64/18.08

      Commit: acce74f3b98ca7886091b652cf58906cf8b302d9c21455940957bf7b3d0343e4
      Parent: 544209aa4dbb698654557f10a23dec944870397bf9e45345f9efd5f7acebb616
     Subject: Update flatpak to 1.2.4 (d10e804c)
        Date: 2019-08-26 12:41:27 +0000

Flatpak version

$ flatpak --version
Flatpak 1.4.3

Description of the problem

error: Failed to execute child process “/app/libexec/flatpak-validate-icon” (No such file or directory)

Note: flatpak-validate-icon exists on the host at /usr/libexec/flatpka-validate-icon:

$ ls -l /usr/libexec/flatpak-validate-icon 
-rwxr-xr-x 1 root root 14600 Sep 19 17:13 /usr/libexec/flatpak-validate-icon

Steps to reproduce

Build any flatpak with an app icon?
Specifically: build https://invent.kde.org/kde/keysmith

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.