The react-18-vector-grid-example from flacoman91

Possibly unnecessary options

@flacoman91 This is a continuation of the conversation on mhasbie/react-leaflet-vectorgrid#16

In this code from your VectorGrid.js file

react-18-vector-grid-example/src/Leaflet/VectorGrid.js

Lines 189 to 211 in d5e183c

 const vectorGrid = useMemo( 

 () => { 

 const options = { 

 rendererFactory: L.svg.tile, 

 interactive: true, 

 style: { 

 weight: 0.5, 

 opacity: 1, 

 color: '#ccc', 

 fillColor: '#390870', 

 fillOpacity: 0.6, 

 fill: true, 

 stroke: true 

 }, 

 type: 'protobuf', 

 vectorTileLayerStyles: vectorTileStyling, 

 apikey: 'gCZXZglvRQa6sB2z7JzL1w' 

 }; 

 return L.vectorGrid.protobuf(nextzenTilesUrl, options) 

 }, 

 [nextzenTilesUrl, vectorTileStyling] 

 );

Lines 194-203 I think are unnecessary. You said in the previous conversation that you

just copy pasted the example from https://github.com/Leaflet/Leaflet.VectorGrid#dependencies

but I can't find any example like that and those options are not documented in the Leaflet.VectorGrid, react-leaflet, or leaflet documentation.

I tried just commenting out those lines entirely and the application still works as expected. To be clear, if you change the current code to look like this, it still worked for me:

const vectorGrid = useMemo( 
     () => { 
         const options = { 
             rendererFactory: L.svg.tile, 
             interactive: true, 
            /*
             style: { 
                 weight: 0.5, 
                 opacity: 1, 
                 color: '#ccc', 
                 fillColor: '#390870', 
                 fillOpacity: 0.6, 
                 fill: true, 
                 stroke: true 
             }, 
             type: 'protobuf', 
            */
             vectorTileLayerStyles: vectorTileStyling, 
             apikey: 'gCZXZglvRQa6sB2z7JzL1w' 
         }; 
  
         return L.vectorGrid.protobuf(nextzenTilesUrl, options) 
     }, 
     [nextzenTilesUrl, vectorTileStyling] 
 );

Lastly, even if you leave that code in, but modify it... it doesn't seem to change anything. For example, the following code renders a map that looks exactly the same as the current code:

const vectorGrid = useMemo( 
     () => { 
         const options = { 
             rendererFactory: L.svg.tile, 
             interactive: true, 
             style: { 
                 weight: 5.0, //notice this changed
                 opacity: 1, 
                 color: '#000', //notice this changed
                 fillColor: '#000000', //notice this changed
                 fillOpacity: 0.6, 
                 fill: true, 
                 stroke: true 
             }, 
             type: 'anything', //notice this changed
             vectorTileLayerStyles: vectorTileStyling, 
             apikey: 'gCZXZglvRQa6sB2z7JzL1w' 
         }; 
  
         return L.vectorGrid.protobuf(nextzenTilesUrl, options) 
     }, 
     [nextzenTilesUrl, vectorTileStyling] 
 );

flacoman91 / react-18-vector-grid-example Goto Github PK

react-18-vector-grid-example's People

Contributors

Stargazers

Watchers

Forkers

react-18-vector-grid-example's Issues

Possibly unnecessary options

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	const vectorGrid = useMemo(
	() => {
	const options = {
	rendererFactory: L.svg.tile,
	interactive: true,
	style: {
	weight: 0.5,
	opacity: 1,
	color: '#ccc',
	fillColor: '#390870',
	fillOpacity: 0.6,
	fill: true,
	stroke: true
	},
	type: 'protobuf',
	vectorTileLayerStyles: vectorTileStyling,
	apikey: 'gCZXZglvRQa6sB2z7JzL1w'
	};

	return L.vectorGrid.protobuf(nextzenTilesUrl, options)
	},
	[nextzenTilesUrl, vectorTileStyling]
	);