Comments (4)
Hi @ccbrandenburg thanks so much for opening this feature request. I would agree with you that it would be beneficial to incorporate the currency
field into the stripe__invoice_line_items
end model.
As you pointed out, this field is available in the upstream models and wouldn't be too difficult to incorporate in the end model. I notice you are interested in contributing this feature to the package! If you would like, this would be a great feature request to open a PR to incorporate within the package. If you open a PR, my team and I will be happy to review and work with you to get the PR in a place to merge into the next release.
If you are interested in opening a PR, let me know if you have any questions as I would be happy to help answer any. Otherwise, my team can pick this feature up in a future update down the line. 😄
from dbt_stripe.
Hey @fivetran-joemarkiewicz happy to create a PR for this.
I just tried to push my commits on my branch but seem to be missing permissions. Do you need to grant me permissions to push to the repo?
Any local testing I need to do or does it all run as part of the CI process?
from dbt_stripe.
Hi @ccbrandenburg you will need to fork this repo and make the changes to your fork. Once your local changes look good you can open a PR to this main
branch on this repo!
If you can do some local testing that would be great. The CI process will kick off regardless once we merge this into our repo.
from dbt_stripe.
Closing this issue out as the currency field is now incorporated in our invoice models!
from dbt_stripe.
Related Issues (20)
- [Feature] Add `paid_out_of_bound` boolean to better identify invoices paid outside of Stripe HOT 5
- [Bug] Timezone conversion doesn't work on postgres HOT 3
- [Bug] Latest Version of Stripe does not reference latest stripe_source HOT 1
- [Feature] Databricks Support
- How to adjust models? HOT 18
- [Bug] Errors when extracting JSON values HOT 12
- Your package relies on older versions of dbt-utils, which means our project is stuck on an older version HOT 2
- Add table rename at the end of each refresh HOT 5
- [Bug] stripe__daily_overview run exceeds memory HOT 1
- [Bug] Error in tmp models due to metadata type json HOT 3
- [FEATURE] metadata columns does not appear summary tables HOT 3
- [Feature] DuckDB Support HOT 1
- [Feature] Be able to leverage package to create MRR reports
- [Feature] Stripe report folder should be renamed to Stripe financial reports
- [Question] Custom metadata column don't use alias feature HOT 3
- [Bug] update date_spine model to accommodate empty `stripe__balance_transactions`
- [Bug] livemode_predicate generates invalid SQL on Redshift: cannot cast type character varying to boolean HOT 5
- [Investigation] Possible fanout in `int_stripe__account_daily` when using connected accounts
- [Investigate] Discrepancy between line item amounts and invoice amounts
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dbt_stripe.