Giter Club home page Giter Club logo

Comments (3)

fivetran-joemarkiewicz avatar fivetran-joemarkiewicz commented on September 3, 2024

Hi @johnf thanks so much for opening this issue!

I see exactly what you are talking about with postgres support for the macro is not possible at the moment. However, you do call out a good point with how dbt_utils handles this currently for postgres. To adjust this macro to allow for postgres support I believe all we would need to do is open a PR that adds a new postgres__date_timezone(column) section within the macro. Similar to how we have it for bigquery:

dbt_stripe/macros/date_timezone.sql

Lines 7 to 14 in de061f7

{% macro bigquery__date_timezone(column) -%}
date(
{{ column }}
{% if var('stripe_timezone', none) %} , "{{ var('stripe_timezone') }}" {% endif %}
)
{%- endmacro %}

I noticed you mentioned you would be open to creating a PR on your end! We are always excited when people from the community want to contribute back to our packages. Please let me know if you would like to work on a PR to account for postgres compatibility in this macro. I am happy to help answer any questions you may have!

Otherwise, my team can tackle this issue in a future sprint. Let me know!

from dbt_stripe.

johnf avatar johnf commented on September 3, 2024

PR ready to roll! :)

from dbt_stripe.

fivetran-reneeli avatar fivetran-reneeli commented on September 3, 2024

Hi @johnf, thank you for opening the PR! We've tested and included your changes to the package. Closing this issue!

from dbt_stripe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.