Comments (4)
Thanks for bringing this up. I think the converter is currently working in the expected fashion. At least, it agrees with every other converter and joint listing I can find (1, 2, 3)
In embolismic years, the 12th month is Adar I, and the 13th is Adar II, so it seems appropriate for hebrew.from_gregorian()
to return 12
and 13
respectively. If you would like to track events that usually occur in the 12th month, but sometimes in the 13th (e.g. Purim), I suggest using hebrew.leap()
to check if it is a leap year.
If I've misunderstood what you're asking, it would be helpful to see a test case that the library would currently fail.
from convertdate.
I already adapted it for our project via using hebrew.leap().
And of course, for computing purposes Adar I is logically the 12th month, but I judge it from halachic point of view. And also my code could have been simpler if the months was swapped. Because to calculate birthdays and Holidays I have to either manually swap 12 and 13 for leap year, or redirect 12th month's events to 13th month anyways. Although, I would still need to use leap()
method to set name for 12th month (Adar or Adar II), but it feels more natural (It remains the same month).
Maybe if chabad.org call a leap year's 12th month Adar I for their converter, then it's OK. But I couldn't find it out from your reference. What exactly did you mean?
from convertdate.
I understand that it's a pain to deal with leap months, but I think the current situation is the most general, easiest-to-understand solution.
Chabad.org doesn't explicitly list Adar I as the 12th month, but it's the 12th month that occurs in their dual-system calendar for AM 5776.
Glad you're finding the library (at least somewhat) useful!
from convertdate.
I didn't state that consequently Adar I is 13'th month, I know it's 12th, if you count from Nissan. I just said it's more profound to make it 13th, even from OOP point of view (since Adar and Adar II have the same events). BTW, additional Adar comes explicitly before the common Adar, unlike in other calendars, so there's no comparison. But I'm cool with the current state, if you don't wanna touch it. It still serves for good things.
Happy Chanukah!
from convertdate.
Related Issues (20)
- install fails with pytz 2020.1 HOT 4
- Confusing example in README HOT 1
- hebrew.to_jd() results differ between Python2 and Python3 HOT 3
- Some US Federal holidays are incorrect and/or incomplete. HOT 1
- Incorrect conversion in Bahá'í calendar for Ayyám-i-Há
- Ordinal is wrong for December 31st HOT 2
- Hebrew Calendar should include method to return date where Tishrei is 1 HOT 7
- hebrew.to_jd_gregorianyear(...) cannot unpack non-iterable float object HOT 5
- Julian Date converstion wrong for astronomical years less than -4716 HOT 2
- Islamic Julian Day conversion incorrect for julian day < 1948085.5 HOT 2
- indian_civil.from_gregorian() wrong for gregorian dates before November 25th, 4714 BCE HOT 1
- julian.leap() always truthy for BC years HOT 1
- Human Era support HOT 1
- Add Buddhist Calendar support HOT 1
- Add Babylonian Calendar support HOT 1
- Migrate CI to github workflows
- LGPL-3.0 dependency HOT 1
- Possibly incorrect results for hebrew calendar if years are small HOT 1
- hebrew.monthcalendar returns a 6-day week HOT 1
- Hijri year before year 1 is year -1 not 0.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from convertdate.