hebrew.to_jd() results differ between Python2 and Python3 about convertdate HOT 3 CLOSED

To add more detail - this is seen on the same host (VM) running Ubuntu 20.04. For both Python 2 and 3 I have a virtualenv with pip install convertdate. convertdate version is 2.2.1 for both of them.

from convertdate.

The short explanation is that the behavior of the Hebrew calendar isn't defined prior to the start of the universe.

The long explanation is that this is due to the differences between division in Python 2 and 3. One of the supporting functions (hebrew.delay_1) performs a calculation that looks like this:

from math import trunc
trunc((235 * year - 234) / 19)

When year is positive, the result in Python2 and 3 is the same. When year is negative, they behave differently. The solution is to add from __future__ import division to the top of the file. The other, perhaps more apt, solution would be to raise an error when year is less than 1.
I'm going to mark this is low priority, since it involves making a change for an invalid calculation in a EOL'd version of the language.

from convertdate.

@fitnr I think it's reasonable for you to close this one, given that python2 was EOL January 1, 2020!

from convertdate.