Giter Club home page Giter Club logo

p-diff's People

Contributors

fistyee avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

p-diff's Issues

Zeta > 0.9 -> not used?

Hi @fistyee ,

thank you for the very interesting paper.

I stumbled upon one point I didn't quite get and could also not figure out from your implementation, so maybe you can help me out.

When estimating the noise, we are using zeta which is the expected value of |delta| in the distribution.

I believe in your code, this is named train_sat here: https://github.com/fistyee/P-DIFF/blob/master/layer/p_diff_layer.cpp#L199

In the paper, you mention that "once zeta is larger than a threshold [0.9], all samples with delta < 0 are regarded as noisy samples to estimate the noise rate tau."

When I think about it, it seems the noise rate is then always pointing to the bucket referring to delta = 0, so the bucket id will be 100 (when using 200 buckets), so we would still use the threshold delta > 0.

I tried to consult your code to figure this out more in detail, but it seems that you skip the computation when zeta > 0.9:
if (T_ <= Tk_ || train_sat < thred_train_sat_) https://github.com/fistyee/P-DIFF/blob/master/layer/p_diff_layer.cpp#L202 in which case the noise ratio would again be calculated to be the bucket referring to delta = 0?

I probably missed sth, so it would be great if you can point me in the right direction. Thank you!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.