Giter Club home page Giter Club logo

Comments (6)

github-actions avatar github-actions commented on August 30, 2024

Congratulations for submitting your first issue on pypact. Thanks for contributing!

from pypact.

thomasms avatar thomasms commented on August 30, 2024

Hi @areedc , is this a bug with the parsing or just the plotting feature of the library? The plotting part of the package is indeed not well maintained, the development effort on that side never took off.

If pypact is failing to parse the FISPACT-II output correctly then that is something that needs fixing - do you think you could share the output file (or example of the file) so I can reproduce and potentially fix this issue?

Thanks for using pypact btw!

from pypact.

areedc avatar areedc commented on August 30, 2024

Hey Thomas. Now I've taken a look. The parser works fine. Metastable isotopes are treated as separate nuclide in the output.InventoryData.nuclide object. This issue is in the plotproperty function.

I wanted to use the plotproperty function to strip out a time series for each nuclide. But that was getting cluttered by combining the metastable nuclides with the ground state.

from pypact.

thomasms avatar thomasms commented on August 30, 2024

OK, so I can indeed see the issue. I think it is this line here: https://github.com/fispact/pypact/blob/master/pypact/analysis/propertyplotter.py#L43, it just ignores the state is just ignored here. With some changes it should be possible to include this.

Feel free to make this changes.

from pypact.

areedc avatar areedc commented on August 30, 2024

Sweet! I just haven't had time to fix it but would have missed the change in pypact/library/nuclidelib.py!

from pypact.

thomasms avatar thomasms commented on August 30, 2024

Fixed in PR #49.

from pypact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.