Comments (6)
Congratulations for submitting your first issue on pypact. Thanks for contributing!
from pypact.
Hi @areedc , is this a bug with the parsing or just the plotting feature of the library? The plotting part of the package is indeed not well maintained, the development effort on that side never took off.
If pypact is failing to parse the FISPACT-II output correctly then that is something that needs fixing - do you think you could share the output file (or example of the file) so I can reproduce and potentially fix this issue?
Thanks for using pypact btw!
from pypact.
Hey Thomas. Now I've taken a look. The parser works fine. Metastable isotopes are treated as separate nuclide in the output.InventoryData.nuclide object. This issue is in the plotproperty function.
I wanted to use the plotproperty function to strip out a time series for each nuclide. But that was getting cluttered by combining the metastable nuclides with the ground state.
from pypact.
OK, so I can indeed see the issue. I think it is this line here: https://github.com/fispact/pypact/blob/master/pypact/analysis/propertyplotter.py#L43, it just ignores the state is just ignored here. With some changes it should be possible to include this.
Feel free to make this changes.
from pypact.
Sweet! I just haven't had time to fix it but would have missed the change in pypact/library/nuclidelib.py!
from pypact.
Fixed in PR #49.
from pypact.
Related Issues (20)
- Apply missing doc strings HOT 1
- Add ability to read DPA HOT 1
- Allow reading of printlib files - printlib5
- Updates to pypact analysis wiki HOT 4
- Bug: cannot read gamma spectra from new fispact output HOT 1
- Bug: Cannot read total mass
- input runner not working correctly
- Need printlib4 reader
- FNS Fission spectra HOT 2
- Question about test91 example HOT 3
- Digit of fuel entries HOT 1
- Length of printed floating points exceeds FISPACT input file limits. HOT 3
- Add python 3.9 to CI HOT 1
- fluxesfile.py: Writing fluxes files using setValue method doesn't set correct groups when small rounding errors present HOT 4
- Add convenience properties to Nuclide HOT 5
- install fails on v1.3.5 from pypi HOT 1
- 'LinePlotAdapter' object has not attribute 'custom' HOT 3
- Check python 3.10+ support
- Reading values missing "E" character for exponentials HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypact.