Version 3.13.1 of eslint just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

need a method that will unbind everything

Discover doesn't actually work if you pass in a selector matching the module itself.

Say you have a button that is not part of the module but you want it to trigger an action in the module, like opening a modal (where the modal is the module). Would this be something that would be useful to put into Domodule core? Not exactly sure the best way it can be implemented. Maybe something the modules themselves setup like so:

class Test extends Domodule {
  constructor(el) {
    super(el);
    this.bindExternal('data-action-modal', this.open, 'click');
  }
}

Use case: Single buttons or modules where the entire element needs to be clickable.

modernized fidel + data-attrs....

html:

<div data-module="Widget" data-module-id="123">
  <input type="text" data-el="textBox"/>
  <button data-action="save"></button>
</div>

js:

class Widget extends Domodule {
   //this is optional 
  constructor(el, options, els) {
   this.super(el, options, els);
   //some stuff here
  }
  actions: {
    save: (el) => {
     const val = this.els.textBox.val();
     const id = this.options.id; //123
    }
  }

}

Features

• on dom ready class automatically gets instantiated for each data-module.
• auto bind actions, els, options from dom
• no jquery needed
• this.find('.blah') does a this.el.querySelector('.blah')

//cc @dawnerd

Version 13.2.0 of browserify just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As browserify is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Sometimes its nice to have an array to work with. What do you think about having a second param on the find call that will convert the NodeList to an array?

Basically run this before returning:
var nodesArray = [].slice.call(document.querySelectorAll("div"));

Proposing adding support for a function that will allow a plugin to add/override methods without having to use a long extends chain.

It could look something like this:

ajax.js

export default class Ajax {
  get(url, data) {
    //...
  }

  post(url, data) {
    //...
  }
}

app.js

import Ajax from './Plugins/ajax.js';
Domodule.registerPlugin(Ajax);

Not sure how we'd handle constructors though.

You think this would be helpful?

Version 3.2.0 of eslint-config-firstandthird just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As eslint-config-firstandthird is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴