Giter Club home page Giter Club logo

comicviewer's People

Contributors

fire-eggs avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

comicviewer's Issues

Bookmarks and image files?

Bookmarks may not be working with image files (not archives)?

See MainDisplay.xaml.cs, LoadAndDisplayComic, TODO

Dynamic Key Hints

Keyboard hints are only visible on startup.

Consider using an InformationWindow to display on-the-fly, e.g. for the '?' key. Or menu.

Idea: "book shelf"

Scan a folder tree containing books
Show a preview of first page(s) in the book
Helpful for spotting duplicates, finding books you want to read

  • Will want to cache files / thumbs : frequent rescans will be painful
  • "first" image in book may not be useful: need to be able to find first "useful" image or allow user control

Nested ZIP doesn't work

A ZIP file containing ZIPped files doesn't work.

Typical situation: a manga volume containing ZIPped chapters.

Crash leaves AsyncLoader alive?

A crash (see next issue) appears to leave the AsyncLoader thread alive. (visual studio can't build because the exe is in use).

Need a last chance exception handler to clean up that thread... ?

Auto-open images

Support opening all images in a folder by:

  1. acting like picture viewer: user opens one image, all images are loaded and can be paged through.
    or
  2. browsing for, and opening all images in, a folder

Async archive loader still 'alive'

It appears the async archive loader may still be alive after the archive is fully loaded.

Manifests in part as memory / handles locked.

Need code cleanup: ArchiveLoadAsync

The quick-and-dirty load of "archive containing archives" has made the code a bit too much of a cobble.

  1. Have lost "async" feature: containing archive has to be fully extracted before any image shown
  2. Too much duplicated code.
  3. 'activeFileNames' cobble.
  4. Passing too many parameters for ExtractFile.
  5. Possibly leaving temp files around (not deleted)

Image File location?

Look into supporting 'location' for individual image files.

See ImageLoader.cs, LoadComicBook, TODO comment.

Multi-archive support broken by async loader

The code suggests that multiple archives can be loaded, and then navigate between them. E.g. Alt+Home, Alt+End, Alt+PageDown, Alt+PageUp.

However, Alt+Home / Alt+End seem to be non-functional.

  1. Using file browser, select multiple ZIPs to load.
  2. Page up/down to nav within first archive.
  3. Alt+PageDown to go to second archive; page down a few times.
  4. Alt+Home should go to beginning of first archive.

Step 4 goes to beginning of 2d archive.

Load folder - All image files in folder

Consider a new feature: "Load folder" which loads all images in the folder.

A possibly "more obvious" implementation of the current behavior of "load a single image automatically loads all images in the folder".

Multi-zero_start : archive load crashes

The "multi_zero_start" archive, when loaded, crashes.

When the files are extracted and opened as files, no crash.

I think it is due to the AsyncLoader logic only loading the first 5 files. As the archive in question has the first 5 files as invalid, we fall over.

The AsyncLoader logic that loads the first 5 files needs to load the first 5 valid files ...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.