finraos / karma-msl Goto Github PK

Modify index.js to allow random setting of port number for msl server using an available port. After this is configured, auto set the proxy to point to this server.

The available port should not clash with karma web server port.

in https://github.com/FINRAOS/karma-msl/blob/master/lib/index.js, there is a line:

require('../node_modules/msl-server/web-server');

This path is wrong for the one of the projects I am working on -- it should be '../node_modules/msl-server/web-server'. As a result, there will be a "node_modules/msl-server/web-server" not found message the first time you try to run karma. Others have reported that uninstalling and reinstalling modules fixes the problem, but this is the root cause (I don't know how reinstallling fixes this).

The current code seems very dependent on whether modules are installed locally or globally. That's a bad idea. If the web-server configuration is project-specific and not generic, then it should be separate, not part of the module itself, and its location passed in as a parameter. Also, referencing a local module should be done according to http://www.bennadel.com/blog/2169-where-does-node-js-and-require-look-for-modules.htm (I haven't tried this myself).

Update plugin to use the latest msl browser client with the following PR included:

FINRAOS/MSL#68