Giter Club home page Giter Club logo

card-game-simulator's Introduction

Card Game Simulator

Card Game Simulator

License: MPL 2.0 Contributor Covenant Test, Build, and Deploy with GameCI Quality Gate Status

The CGS website is available through GitHub Pages in the docs/ folder: https://www.cardgamesimulator.com

For user documentation, see the wiki: https://github.com/finol-digital/Card-Game-Simulator/wiki

Additional games are available from the CGS Games website: https://cgs.games

Lastly, some additional resources are on Google Drive: https://drive.google.com/open?id=1kVms-_CXRw1e4Ob18fRkS84MN_cxQGF5

Building and Running

Built with Unity

To build and run the project, you just need to clone the repo and run it in Unity, available from https://unity.com/download

Contributing

If you'd like to help out with the project, either join our Discord or email [email protected]

License

Code released under the Mozilla Public License 2.0

card-game-simulator's People

Contributors

cjmiiiy avatar davidmfinol avatar dependabot[bot] avatar katori avatar paulpach avatar sanshelvetica avatar slib53 avatar timpickup avatar uweeby avatar xhosant avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

card-game-simulator's Issues

Flipped/Masked Cards Contents Can Still Be Viewed

Describe the bug
When a card is flipped over another user is able to view the name and the card.

To Reproduce
Steps to reproduce the behavior:

  1. Load a deck of cards
  2. Draw a card and place it face down
  3. Have another user hover over the card, they can see the name and double click the card to view the card.

Expected behavior
When a card is flipped over I would expect only for the owner of the deck to be able to see the card name and contents.

Can there only be 1 image for all cardbacks?

Awesome job making this! I'm having lots of fun playing with it. Is there a way to have more than one CardBack for different decks? As I understand it, the CardBackImageUrl is the only pic for a cardback, and acts as a global back image for all cards. Is there, or can there be, a way to have another image for all cards of a certain SetId?
Many thanks!

Describe the solution you'd like
To be able to see multiple decks on the table with different cardback pictures

Describe alternatives you've considered
i dunno, i'm a newb

Additional context
Add any other context or screenshots about the feature request here.

Application Freezing When Loading Cards

Describe the bug
The application frequently freezes when loading images. If I have to load 5 cards on the screen, the entire application will show that it's not responding then. After about 1 - 2 minutes it will eventually load, this is even worse the more cards I attempt to view at once.

This is causing me numerous issues when I begin attempting to play with someone. If we have to search our deck, the application will lock up and in some cases will drop a user from the game session. This causes them to lose all their progress, in some cases they can rejoin but do not see board pieces that had been previously placed.

As the host when I went to search my deck, my application locked up and this shutdown the entire lobby. Also wiping the entirety of the board state.

To Reproduce
Steps to reproduce the behavior:

  1. Load large resolution images that are at least 1250 DPI (My Image resolution is 4055x5917)
  2. Attempt to view a deck of more than 200 cards.
  3. The application freezes for 1 - 2 minutes (sometimes longer)
  4. No error is presented. The application freezes.

Expected behavior
I would expect to be able to view these images without any more than a 1 - 2 seconds delay.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser N/A
  • Version v1.103

Desktop (please complete the following information):

  • OS: OSX
  • Browser N/A
  • Version v1.103

Additional context
The problem occurs for both me and my friend who are attempting to use the application. We have different operating systems, but the experience is the same on both computers. When loading a card, or deck the entire application locks up and freezes.

Open Pdf Fails

CGS will create the PDF file, but it will fail to automatically open it, so the user has to manually navigate to the file to open it.

closing drawer makes cards in hand disappear

Describe the bug
cards in your Hand disappear even tho the number for cards in hand are still there.

To Reproduce
Steps to reproduce the behavior:

  1. Put cards in your Hand.
  2. Click on the '+' to open a new Drawer.
  3. Click on the tab for your Hand to ensure you are still viewing your Hand.
  4. X out a Drawer.
  5. see error

Expected behavior
For the Drawer to go away but any cards in Hand should still be there and visible

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Win10
  • Browser chrome
  • Version 123.0.6312.106 (Official Build) (64-bit)

Smartphone (please complete the following information):
seems to work fine on Android pixel 6

Additional context
But on Win10 desktop chrome, seems like any tab (Hand or Drawer) that you are looking at, when you close some other Drawer (even if it's empty), the cards you're currently looking at will disappear with the number for how many cards were in there still remaining. I've tried minimizing/maximizing the Hand/Drawers, Adding/removing other tabs, and can't seem to bring them back.... this might be connected to a slightly different issue regarding drawers being crossed. Will make another report.

Unable to delete dice, tokens, or decks from play area

Describe the bug
In the android app, when selecting a dice, deck, or token in either single or multiplayer modes, tapping delete does not remove the item. I also tried dragging the item over delete as well, same behaviour. Once the button is tapped, the pulldown menu (with the dice +- and delete button) disappears but the item remains on the playing field.

To Reproduce
Steps to reproduce the behavior:

  1. Start a game with standard 52 card deck
  2. Place a token on the field
  3. Tap the token, and then tap delete

Expected behavior
The item should be removed from the playing field.

**Platform

  • OS: Android 13
  • hardware: Samsung s21 ultra
  • browser: iceraven 2.6.1
  • app version: Card Game Simulator 1.87.0 (play store)

Additional context
Great software, thank you for your efforts.

Other Users Do Not See Rotated Card

Describe the bug
When rotating a card in a multiplayer lobby, other users do not see the card being rotated.

To Reproduce
Steps to reproduce the behavior:

  1. Place a card
  2. Rotate that card
  3. Ask if the other user is able to see if the card has been rotated. In my experience only the user whom rotated the card is able to see the card has been rotated.

Expected behavior
I would expect the card state to be consistent for all users, if a card is rotated everyone should see this card has been rotated on the board.

Windows Client not finding LAN games

Describe the bug
Local Discovery not finding LAN game on Windows

To Reproduce
Host Local game
Try to join from Windows Client

Expected behavior
Local Games should be able to found if on the same LAN

Allow setting an exact value to a dice, for use as counters

FEATURE REQUEST

Is your feature request related to a problem? Please describe.
Some of the games I play need counters, like placing a dice set to 5 on the card to signify +5 to the card. In the current system, I need to set the dice by tapping + and - a bunch of times from whatever random value it rolled to when I created it, particularly with large numbers like 15 which would use larger dice or multiple dice in real life.

Describe the solution you'd like
Allow players to set a value to the dice, with either an entry box for typing or larger increments for the + - buttons when setting the dice (such as +5, +10, etc), so that they can be used as counters. Preferably, there would be a tickbox to disable rolling the dice (to prevent rolling by accident when double tapping in android, allthough this is optional since I could just turn that off in the settings menu), and also the value should be able to surpass the max value of the dice (for example, spawn a dice and set it to 15, regardless of the faces setting in the settings menu). This could also be done with a seperate game object, if going past the number of faces set in the settings menu is a problem. Negative numbers (or, alternatively, dice colors that can be set per-dice) would also be nice for delegating different kinds of counters, but don't want to ask for too much :)

Describe alternatives you've considered
Implementing counters seperately, spawning large numbers of tokens, or have "decks" of counters and simply search the deck when needed.

Additional context
Was just submitting a bug and thought I'd chip this in as well. I'll work around it for now though, I can still play with regular dice, just a bit more tedious :) . Love your app, excellent work. Thanks.

Ability to draw multiple cards to your hand.

Is your feature request related to a problem? Please describe.
I would like to define a number of cards to draw to my hand. I could not find a way to do this within the existing application.

Describe the solution you'd like
I would like to be able to right click on the card, then select Draw multiple cards.
I should then be prompted to enter a number, so I can draw X cards.

Additional context
This is useful for Trading Card Games that have card effects which cause you to draw 2 cards.
This is useful for the start of game, when players need to draw 6+ cards to their hand.

Can't place a card from hand to the table face down

Describe the bug
Not able to easily put a card face down on the table.

To Reproduce
double tapping the card while it's in my hand doesn't turn it face down, and playing it on the table keeps it face up

Expected behavior
Double-tapping should turn the card facedown

Additional context
Android

Infinite loop when trying to import a banner for a new game

When trying to import a banner image for a game, the file open dialog keeps popping up indefinitely regardless of whether you select an image or press cancel. The app must be terminated from Task Manager to exit the loop.

To Reproduce
Steps to reproduce the behavior:

  1. Click the "+" in the main screen to create a game
  2. Click the "+" in the Banner section
  3. Choose an image and press "Open", or press "Cancel"

Expected behavior
The file open dialog is closed.

Actual behavior
The file open dialog pops up again and again, indefinitely. The title of the dialog is "Select Card Back Image File" and chosing an image changes the Card Back, even though I clicked the button for importing a Banner. Seems like the first time the dialog pops up, it changes the Banner, but on following dialogs it changes the Card Back.

Desktop:

  • OS: Windows
  • Steam
  • Version 1.83

Images of cards within Hand/multiple Drawer tabs

Describe the bug
With cards in Hand and in multiple (2+) Drawer tabs, when closing one of the Drawer tabs other than the one immediately next to the Hand, the incorrect cards disappear and the count for how many cards in each tab gets messed up.

To Reproduce
Steps to reproduce the behavior:

  1. Put 1 card in Hand.
  2. create Drawer and put 1 card in drawer (now called "drawer1")
  3. Create another Drawer and put 2 cards in this drawer (now called "drawer2")
  4. Make another Drawer and put 3 cards in this one (now called "drawer3")
  5. Delete "drawer3" by clicking on the X for its Drawer.
  6. see error in "drawer2" (somehow the cards from drawer3 have now replaced the cards of drawer2

Expected behavior
The Drawer with the correct cards to still be there.
Hand should have 1
Drawer1 should have 1
Drawer2 should still have 2
(Drawer3 was removed/closed out)

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Win10
  • Browser chrome
  • Version 123.0.6312.106 (Official Build) (64-bit)

Smartphone (please complete the following information):
seems to work fine on Android pixel 6

Additional context
seems like if all the open Drawer tabs were a linked list, that the game is always deleting the card images from an incorrect node of the list and propagating the images over, but handling the number of cards that's supposed to be in each tab correctly. I have only encountered this with a desktop pc's browser for playing in web mode. Using the phone app CGS seems to be fine.

Send Input to Maple

Maple is a subsystem that receives external data via its PubSub interface once Maple has been initialized. The PubSub interface takes "payload" objects, and subscribers should process payloads with polymorphism. The payload types are defined in /Maple/PubSub/Payloads.cs.

To receive user input, the parent system should send input information to Maple in the form of a FingerSlidePayload. The destination is open for discussion, but I suggest sending to the topic path Ingress.Input.FingerSlide.

Once this task is completed:

  • Subscribers should receive a FingerSlidePayload when taking messages

Game Download Progress Freezes

This is an intermittent issue:
Sometimes, the Game Download Progress bar will freeze. I've only noticed it when downloading Decks, and when it happens in the Unity Editor, there is a cryptic error message that relates to co-routines.
Can we move the entire Game Download process away from co-routines to async/await resources?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.