finn-no / carousel-js Goto Github PK
View Code? Open in Web Editor NEWOur general purpose carousel widget which can be used for multiple use-cases.
License: Other
Our general purpose carousel widget which can be used for multiple use-cases.
License: Other
I'd like to contribute some more stuff, but it would be a shame to break the tests. :)
โ carousel-js git:(master) grunt jstestdriver
Running "jstestdriver" task
>> Total Passed: 0, Fails: 0
Done, without errors.
Notice the "Total Passed: 0"
we should automate the release process by adding some Grunt tasks to do it correctly for Bower and NPM.
it should also do tagging.
Hello,
Are you still maintaining this repo as a bower package?
I'd like to discuss possibly taking this over on my new Carousel package I have here:
https://github.com/mkay581/carousel-js
Feel free to take a look and let me know your thoughts.
Thanks,
Including version number in dist files like carousel-1.1.0.js would force hardcoding version number in other pars like <script src="...">, and this would make a hassle when upgrading. So please trip away the version number.
The bug can be seen here: http://www.finn.no/oppdrag/356286/bilder?index=1
What happens is that the first image is loaded first, and the load callback for this image fires after the second image (index=1) is shown.
lazy image list only supports images, it shouldn't care if there is another DOM element present in the carousel.
it should just add the item without any delays or anything.
Right now you must have jQuery to use some modules. There really isn't a need for that just to do some simple DOM traversal and simple animations.
The DOM stuff should be written without any framework. The animations should have an option of using something other than jQuery or perhaps to only use CSS.
The function downloadAlternativeImageWhenNotFound should be renamed to not specify an image.
Also the errorCallback isn't really an error callback, as it is more an "alternative path resolver" when loading of images fails. This isn't reflected in the name
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.