Comments (4)
It would be nice to have it, but post-0.5.
from finalfrontier.
I had a look into this today, this is messy.
The only case where serialization of a context-model is straight forward, is for skipgram. Although structgram and dirgram both have stringly keys, we still need some additional typing in order to distinguish between different offsets. This could certainly be done by appending numbers to the vocab items, but we'd need to handle this for all models differently and wouldn't be able to do so in a common implementation.
Also, while writing this I ended up with this monster of a fn signature for a generic implementation of the writing trait:
impl<W, T, IV, OV, M> WriteModelBinaryWithContexts<W> for TrainModel<T>
where
W: Seek + Write,
T: Trainer<InputVocab = IV, OutputVocab = OV, Metadata = M>,
M: Serialize,
IV: Vocab<VocabType = String>,
for<'a> &'a IV::IdxType: IntoIterator<Item = u64>,
OV: Vocab<VocabType = String>,
for<'a> &'a OV::IdxType: IntoIterator<Item = u64>,
for<'b> VocabWrap: From<&'b IV> + From<&'b OV>,
from finalfrontier.
Meh, too large a type signature indeed.
from finalfrontier.
I'm not working on this and I don't think there's any interest for it, closing this for now.
from finalfrontier.
Related Issues (20)
- Replace custom fallible conversion methods by TryFrom
- Automatic builds of binary packages are broken? HOT 1
- Dealing with different set of command-line options HOT 4
- Thank you
- Include generated man pages in release builds
- Make a Homebrew tap for macOS release builds HOT 1
- Training without subwords HOT 2
- Implement ASAG and AsySVRG HOT 1
- Release 0.6 HOT 12
- Add support for vocab size target HOT 1
- Support explicitly stored ngrams HOT 90
- Broken CI script
- Some general vocab questions HOT 28
- Fix EOS ngrams
- Document side-effects of increasing the number of threads HOT 6
- Store the number of threads in metadata HOT 1
- Provide subcommand to generate completions HOT 2
- Kick out EOS marker HOT 1
- Add overarching `finalfrontier` man page HOT 1
- Replace underscores by dashes in options
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from finalfrontier.