Giter Club home page Giter Club logo

Comments (2)

danieldk avatar danieldk commented on June 1, 2024

See #46 and #47 .

I still don't like the data structures in either PR. I feel like they do not really clearly convey the semantics. I don't have a perfect solution yet. One rough idea is to have a single struct:

struct WordIndex<S>
where
    S: AsRef<[usize]>,
{
    word_idx: usize,
    subword_indices: S,
}

impl WordIndex<[usize; 0]> {
    fn new(word_idx: usize) -> Self {
        WordIndex {
            word_idx,
            subword_indices: Default::default(),
        }
    }
}

impl WordIndex<Vec<usize>> {
    fn new_with_subwords(word_idx: usize, subword_indices: impl Into<Vec<usize>>) -> Self {
        WordIndex {
            word_idx,
            subword_indices: subword_indices.into(),
        }
    }
}

impl<S> WordIndex<S>
where
    S: AsRef<[usize]>,
{
    fn word_index(&self) -> usize {
        *self.word_index
    }

    fn subwords_indices(&self) -> &[usize] {
        self.subword_indices.as_ref()
    }
}

Then the rest of finalfrontier can be oblivious to subwords.

from finalfrontier.

sebpuetz avatar sebpuetz commented on June 1, 2024

Merged in #54

from finalfrontier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.