The filepreviews-node from filepreviews

filepreviews-node's People

Contributors

Stargazers

Watchers

filepreviews-node's Issues

Handle null response in onError handler

Hi guys,

Just discovered an error that might be occurring since we upgraded to Node v16.13.2 (from 12), though it's potentially been happening for previous versions and we've only noticed it now because it now crashes our servers - due to the unhandled exception change in Node.

Anyway, it seems the onError handler isn't safe if the response is null.

filepreviews-node/lib/index.js

Lines 89 to 92 in 3c6c5f3

 var onError = function(error, response, body) { 

 this.log('API request error: ' + error); 

 this.log('API request response:', body); 

 this.log('API request error: ' + response.statusCode);

See the stack trace below:

/home/ubuntu/www/node_modules/filepreviews/lib/index.js:92
    this.log('API request error: ' + response.statusCode);
                                              ^

TypeError: Cannot read properties of undefined (reading 'statusCode')
    at FilePreviews.<anonymous> (/home/ubuntu/www/node_modules/filepreviews/lib/index.js:92:47)
    at Request._callback (/home/ubuntu/www/node_modules/filepreviews/lib/index.js:135:9)
    at self.callback (/home/ubuntu/www/node_modules/request/request.js:185:22)
    at Request.emit (node:events:390:28)
    at Request.emit (node:domain:475:12)
    at Request.onRequestError (/home/ubuntu/www/node_modules/request/request.js:877:8)
    at ClientRequest.emit (node:events:390:28)
    at ClientRequest.emit (node:domain:475:12)
    at TLSSocket.socketErrorListener (node:_http_client:447:9)
    at TLSSocket.emit (node:events:390:28)
    at TLSSocket.emit (node:domain:475:12)
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at emitErrorCloseNT (node:internal/streams/destroy:122:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)

Thanks!

Version 2.0

We're getting ready to release v2 of the FilePreviews API. We already have a reference implementation of in filepreviews/filepreviews-python#3 which we're using to update libraries.

Typescript support

DO you plan tu support typescript for this lib ?

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

filepreviews / filepreviews-node Goto Github PK