ffmbybicycle / brouter-cycling-profiles Goto Github PK

We should avoid ways with "cycleway:lane=advisory". Currently this isn't possible due to missing lookup data: abrensch/brouter#416

The cost (?) for a probablyGood cycleway seems to be higher (1.1) than if nothing special is known about the cycleway (1.0). I don't understand much about the routing profile format, but looking at other similar if else cases, this seems to be in the wrong order here.

I was just having a look at your profile and comparing it with my personal preference and local knowlede of my "optimised" routes. While doing so, I found out that your profile misses a couple of surfaces:

• concrete:lanes is better than ground/grass but worse than concrete because there can be small steps between the plates (depends on age and region).
• concrete:plates is used for pre-fabricated concrete plates (but I expect some mappers to use it for in-situ concrete as well. True concrete plates roads are horrible, especially in former GDR (having lived there for a couple of years).
• metal: worse than asphalt, better than concrete plates, common on bridges for pedestrians and cyclists
• grass_paver: horrible to ride, unusual as surface except parking slots and short sections on agricultural tracks

You might compare your profile with https://taginfo.openstreetmap.org/keys/surface#values and https://taginfo.geofabrik.de/europe/germany/keys/surface#values

At the moment shared bus/bicycle lanes are ignored if not mapped as "cycleway=lane"

These are currently ignored, but should be used to get even better results.

Example: https://bikerouter.de/#map=15/50.2658/8.7179/standard&lonlats=8.720999,50.262488;8.717824,50.274202&profile=ffmbb-long-distance-cycling

There is a good alternative: https://bikerouter.de/#map=15/50.2677/8.7190/standard&lonlats=8.720999,50.262488;8.72276,50.269873;8.717824,50.274202&profile=ffmbb-long-distance-cycling

It seems that the if clause does not handle steps as desired.
Probably only the 'not' needs to be shifted to ramp:wheelchair=yes?

if ( and not highway=steps ramp:wheelchair=yes ) then ( if allow_steps then 40 else 9999 )
  else if ( route=ferry   ) then ( if allow_ferries then 5.67 else 9999 )