fenilgmehta / cs765-simulate-p2p-cryptocurrency-network Goto Github PK

What is the problem

• The below formula which is present at resources/T_k_Calculation.png and used in Node.__init__(...) seems to create problem with block mining power (i.e. Node.T_k_exp_block_mining_mean)
  
• The numerator (i.e. numpy.random.exponential() in the code) in the third formula, can make a node with low hashing power mine blocks very fast and a node with high hashing power mine blocks slowly.

Please have a look at the below lines of code:

• https://github.com/fenilgmehta/CS765-Simulate-P2P-CryptoCurrency-Network/blob/main/src1/simulator.py#L1454
• https://github.com/fenilgmehta/CS765-Simulate-P2P-CryptoCurrency-Network/blob/main/src2/simulator.py#L1508

The message of the print statement and the variables being used do not seem logically correct

What is the issue ?

The following error occurred during execution (ignore the line numbers as code was modified before execution)

Traceback (most recent call last):
  File "simulator.py", line 1644, in <module>
    Main(vars(args))
  File "simulator.py", line 1564, in Main
    status = mySimulator.execute_next_event()
  File "simulator.py", line 320, in execute_next_event
    event = self.event_queue.pop()
  File "simulator.py", line 1193, in pop
    return heapq.heappop(self.events)[1]
TypeError: '<' not supported between instances of 'Event' and 'Event'

When does it occur ?

• The event queue is of type List[Tuple[float, Event]]
• Mostly, the error occurs when float values are same for two entries of the event queue which are being compared. So, since first element of the Tuple are equal, Python automatically compares the elements at index 1 (i.e. the Event value will be compared using < operator)

Solution

• Implement __lt__ for class Event and make the event queue as List[Event]
  • We can make event queue object from Tuple[float, Event] ---> Event because the float value is taken from the Event object itself

What is the problem ?

• Node.block_generation_count is getting incorrectly calculated
• Node.block_generation_count needs to be decremented for all occurrences of event.EVENT_BLOCK_CREATE_SUCCESS when mySimulator.global_time > simulatorParameters.execution_time

Where to look in the code for fixing ?

• Line in src1/simulator.py https://github.com/fenilgmehta/CS765-Simulate-P2P-CryptoCurrency-Network/blob/main/src1/simulator.py#L324
• Similarly for src2/simulator.py

• Complete Assignment 2 code/solution
• Write a report
• Add the report to this repository with name CS765_Report_Assignment-2.pdf
• Update the README.md file

• Create document describing each component of the config.json file
  • All decimal points are important in the config file because attributes with decimal mean that they are float and those without decimal point mean that they are integers

What to do ?

• __create_connected_graph method is to be updated to make use of Zeta (ζ) and number_of_individual_attacker_nodes
  • Zeta (ζ) = fraction of honest nodes an adversary/attacker is connected to

Where to do ?

• Will have to think of a way to do this for two situations at https://github.com/fenilgmehta/CS765-Simulate-P2P-CryptoCurrency-Network/blob/main/src2/simulator.py#L317
  • Number of attackers = 1
  • Number of attackers > 1

Anything more ?

• Also have to find a way to check if it is possible to make a graph with specific values of parameters n_total_nodes, number_of_individual_attacker_nodes and ζ, and print an appropriate message