feniix / asdf-sops Goto Github PK

I tried to install v3.8.1 of SOPS, but it fails, because the file name has changed:

$ asdf install sops 3.8.1
Downloading sops from https://github.com/mozilla/sops/releases/download/v3.8.1/sops-v3.8.1.linux
Error: URL responded exceptionally
chmod: cannot access '/home/jan/.asdf/installs/sops/3.8.1/bin/sops': No such file or directory

The file is not called sops-v3.8.1.linux (since 3.8.0-rc.1). Instead it is now called sops-v3.8.1.linux.amd64 (for linux).

It looks like the SOPS repository moved from https://github.com/mozilla/sops to https://github.com/getsops/sops. As a result, the list-all curl call returns this JSON:

{
  "message": "Moved Permanently",
  "url": "https://api.github.com/repositories/40684033/releases",
  "documentation_url": "https://docs.github.com/v3/#http-redirects"
}

This does obviously not work for listing the actual versions. I suspect, installation versions does also break.

As a solution, the URL should be changed to the new one and the curl-call should follow redirects to not break when something like this happens again.

the new naming structure is only available for assets of the last 2 versions, anything older is broke now.

Thanks for this plugin 👍
Unfortunately, the list versions does not seem to work.
Seems related to a github API rate limit on mozilla/sops repo... can you confirm ?
If this is the case, is it possible to return a user-friendly error in the list-all script please ?

asdf install sops latest sadly happens to still pick 3.4.0 tag yet v3.6.1 exists.
https://github.com/mozilla/sops/releases/latest

I see that there is logic to prepend v to the version number if it is before a version:

https://github.com/feniix/asdf-sops/blob/master/bin/install#L17

  if [[ ! (${version} =~ [1-3]\.[0-4]) ]]; then
    # version is greater than 3.4.0
    version="v${version}"
  fi

The install path does not respect this, as such you can have a scenario where the same version can be downloaded twice.

asdf install sops 3.6.0
asdf install sops v3.6.0

$ ls ~/.asdf/installs/sops/
3.6.0 v3.6.0