Comments (7)
Ecto.DataType
protocol might be an alternative. But not sure how that effects things.
So I guess I'm willing to see Ecto.DataType
implemented instead as long as things work as is, or the differences are known and documented
from geo.
@bryanjos the concern I have is when I dont want to GeoJSON as my formatting for example.
Because of this, when you do field :name, Geo.[Type]
we will need to have 3 different types for Point
because you want to cast it to the correct format, for example.
Geo.JSON.Point
, Geo.WKT.Point
, Geo.WKB.Point
unless we use a generic one that fallbacks back to each formatter (which I would like to not do that).
Unless we roll with just one and create some changesets that transform from on formatting to the other.
Not quite sure what is the best movement here, GeoJSON is perfect if you don't care about saving a bunch of bytes, which for some could be the concern, I guess.
from geo.
I'm not sure I understand what is meant, having three structs for the same type isn't something I'm willing to accept. Unless there is a way to move the ecto-specific code to geo_ecto and keep functionality the same, I would say to keep things the same until a time where it is possible
from geo.
I can do some exploratory work to see if it's possible
from geo.
@bryanjos I dont need 3 different ecto types for each data type but don't forget that some people could be interested in specific formatter over GeoJSON, that is why I am bringing it into the table so we think about it.
from geo.
@yordis I was able to move ecto code to geo_postgis completely
from geo.
@bryanjos amazing job mate! Thanks a lot!
I am super happy to see how clean and lean the project is now 😄
from geo.
Related Issues (20)
- is .tool-versions necessary? HOT 1
- Support for `Feature` and `FeatureCollection` to Geo.JSON HOT 2
- Geo.WKB and raw binaries HOT 5
- GeoJSON default SRID not set HOT 1
- The new 'Feature' does not retain the SRID property when encoding HOT 1
- Flatten GeometryCollection into non-complex geometries HOT 1
- Add box2d type HOT 1
- Unable to decode WKB of MultiLineString with no coordinates
- ArgumentError in Geo.WKB.Encoder.do_encode/2(geo 3.4.2) HOT 2
- Multi Linestring with 'EMPTY' in the point throwing error HOT 3
- GeoJSON coordinates are not check nor converted to a numeric value
- Fix handling of GeoJSON Z and M coordinates HOT 1
- Feature GeoJSON with Geometry object of type GeometryCollection is not supported HOT 2
- Feature object with null geometry is not supported HOT 2
- Addition of Circle Geometry HOT 1
- Improve WKB and WKT encoder/decoder HOT 1
- Using geometry types with sqlite_ecto2 HOT 2
- Issue parsing geometry HOT 2
- Geo.JSON does not support PointZ HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geo.