Giter Club home page Giter Club logo

Comments (7)

bryanjos avatar bryanjos commented on September 27, 2024

Ecto.DataType protocol might be an alternative. But not sure how that effects things.

So I guess I'm willing to see Ecto.DataType implemented instead as long as things work as is, or the differences are known and documented

from geo.

yordis avatar yordis commented on September 27, 2024

@bryanjos the concern I have is when I dont want to GeoJSON as my formatting for example.

Because of this, when you do field :name, Geo.[Type] we will need to have 3 different types for Point because you want to cast it to the correct format, for example.

Geo.JSON.Point, Geo.WKT.Point, Geo.WKB.Point unless we use a generic one that fallbacks back to each formatter (which I would like to not do that).

Unless we roll with just one and create some changesets that transform from on formatting to the other.

Not quite sure what is the best movement here, GeoJSON is perfect if you don't care about saving a bunch of bytes, which for some could be the concern, I guess.

from geo.

bryanjos avatar bryanjos commented on September 27, 2024

I'm not sure I understand what is meant, having three structs for the same type isn't something I'm willing to accept. Unless there is a way to move the ecto-specific code to geo_ecto and keep functionality the same, I would say to keep things the same until a time where it is possible

from geo.

bryanjos avatar bryanjos commented on September 27, 2024

I can do some exploratory work to see if it's possible

from geo.

yordis avatar yordis commented on September 27, 2024

@bryanjos I dont need 3 different ecto types for each data type but don't forget that some people could be interested in specific formatter over GeoJSON, that is why I am bringing it into the table so we think about it.

from geo.

bryanjos avatar bryanjos commented on September 27, 2024

@yordis I was able to move ecto code to geo_postgis completely

from geo.

yordis avatar yordis commented on September 27, 2024

@bryanjos amazing job mate! Thanks a lot!

I am super happy to see how clean and lean the project is now 😄

from geo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.