Comments (5)
bryanjos
commented on September 27, 2024
Hi @wojtekmach that sounds reasonable and I always had a feeling there was a better way to do it. Go for it! And thanks!
from geo.
bryanjos
commented on September 27, 2024
@wojtekmach hey I've been thinking about this a lot and I think I may slowly take this on. Doing a small benchmark I can see there are some performance gains in doing so
Operating System: macOS
CPU Information: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Number of Available Cores: 12
Available memory: 16 GB
Elixir 1.11.2
Erlang 22.3
Benchmark suite executing with the following configuration:
warmup: 2 s
time: 5 s
memory time: 0 ns
parallel: 1
inputs: none specified
Estimated total run time: 14 s
Benchmarking binaries...
Benchmarking io_data...
Name ips average deviation median 99th %
io_data 5.16 K 0.194 ms ±15.30% 0.188 ms 0.34 ms
binaries 0.34 K 2.90 ms ±6.84% 2.85 ms 3.81 ms
Comparison:
io_data 5.16 K
binaries 0.34 K - 14.97x slower +2.71 ms
from geo.
wojtekmach
commented on September 27, 2024
Yeah, I kept putting this off. Thanks for looking into it!
from geo.
bryanjos
commented on September 27, 2024
@wojtekmach thanks for motivating me to change this! I made a PR with the changes if you want to take a look.
from geo.
wojtekmach
commented on September 27, 2024
Closing in favour of the PR!
from geo.
Related Issues (20)
- Improve WKB and WKT encoder/decoder HOT 1
- Using geometry types with sqlite_ecto2 HOT 2
- Issue parsing geometry HOT 2
- Geo.JSON does not support PointZ HOT 6
- is .tool-versions necessary? HOT 1
- Support for `Feature` and `FeatureCollection` to Geo.JSON HOT 2
- GeoJSON default SRID not set HOT 1
- The new 'Feature' does not retain the SRID property when encoding HOT 1
- Flatten GeometryCollection into non-complex geometries HOT 1
- Add box2d type HOT 1
- Unable to decode WKB of MultiLineString with no coordinates
- ArgumentError in Geo.WKB.Encoder.do_encode/2(geo 3.4.2) HOT 2
- Multi Linestring with 'EMPTY' in the point throwing error HOT 3
- GeoJSON coordinates are not check nor converted to a numeric value
- Fix handling of GeoJSON Z and M coordinates HOT 1
- Feature GeoJSON with Geometry object of type GeometryCollection is not supported HOT 2
- Feature object with null geometry is not supported HOT 2
- Addition of Circle Geometry HOT 1
- ensure_numeric in JSON.Decoder breaks when the string is an integer. not a float HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geo.