Giter Club home page Giter Club logo

Comments (3)

felixguendling avatar felixguendling commented on June 2, 2024

Looks like it's this line?

std::enable_if_t<is_tuple_v<decay_t<T1>> && is_tuple_v<decay_t<T2>>, bool>`

In general, I think the line should be valid C++ code as it is. The CI build on Windows with MSVC seems to work fine.

Does it work if you change line 6395 to inline constexpr bool is_tuple_v = is_tuple<T>::value;? (just replace auto to bool)

from cista.

nescirem avatar nescirem commented on June 2, 2024

Replacing auto with bool fixed errors: C2296,C2297, but other error messages appeared when compiling with Visual Studio 2017 (Only part of the error message is intercepted here):

...
\cista-0.14\include\cista/serialization.h(237): error C2228: left of '.ptr_' must have class/struct/union 
\cista-0.14\include\cista/serialization.h(237): error C2672: 'cista::member_offset': no matching overloaded function found 
\cista-0.14\include\cista/serialization.h(237): error C2780: 'cista::offset_t cista::member_offset(const T *,Member T::* )': expects 2 arguments - 1 provided 
\cista-0.14\include\cista/serialization.h(49): note: see declaration of 'cista::member_offset' 
\cista-0.14\include\cista/serialization.h(237): error C2780: 'cista::offset_t cista::member_offset(const T *,const Member *)': expects 2 arguments - 1 provided 
\cista-0.14\include\cista/serialization.h(42): note: see declaration of 'cista::member_offset' 
\cista-0.14\include\cista/serialization.h(241): error C2672: 'cista::member_offset': no matching overloaded function found 
\cista-0.14\include\cista/serialization.h(241): error C2780: 'cista::offset_t cista::member_offset(const T *,Member T::* )': expects 2 arguments - 1 provided 
\cista-0.14\include\cista/serialization.h(241): error C2780: 'cista::offset_t cista::member_offset(const T *,const Member *)': expects 2 arguments - 1 provided 
...

Seems that some new std of c++17 are used, and it can no longer be compiled with vs2017?

from cista.

felixguendling avatar felixguendling commented on June 2, 2024

Maybe you can replace the content of the cista_member_offset macro to return static_cast<::cista::offset_t>(offsetof(Type, Member));?

Seems that some new std of c++17 are used, and it can no longer be compiled with vs2017?

Yes, we're targeting specifically C++17 at the moment. I don't have VS2017 at hand to check releases for compatibility but we check with whatever is provided in GitHub Actions CI with C++17 flags set.

from cista.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.