feedzai / eslint-config-feedzai Goto Github PK

Like

return (
    <div
        className="bob"
>
    </div>
);

Should be:

return (
    <div
        className="bob"
    >
    </div>
);

To improve code readability we should add no-multiple-empty-lines option to our current configuration.

https://eslint.org/docs/rules/no-multiple-empty-lines

WDYT about this rule?

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-boolean-value.md

As talked with @lfac-pt, at Pulse the common usage is <Comp prop={true} />.

After integrating these configurations on Pulse, I've noted that now the operator on multiline conditions is placed on the beginning of the new line

What is your opinion on this rule?
operator-linebreak

Personally I prefer to have the operator at the end of the line instead of having it on the beginning of the new line.

The description for rule "react/jsx-no-undef" is currently:

I would recommend changing to something like "Prevent undeclared variables in JSX"

In order for us to use React Hooks we should update our rules.

Right now, the jest rules are included in the eslint-config-feedzai-react and in my opinion, we should remove that rules from eslint-config-feedzai-react and put them into the base package.

I recommend this change because jest rules could be applied to other projects that don't use React.

Don't you agree (@lfac-pt @nancruz)?