featurehub-io / featurehub-ruby-sdk Goto Github PK

Hey there! This SDK is awesome. My team is looking into using Featurehub within a Rails application, and using this SDK appears to be preferable to us compared to building a client from the OpenAPI Spec (which is also great to have). I do have a couple of questions about the project and I'm hoping this is the correct place to ask. If not, feel free to close the issue and, if you have time, point me in the right direction.

I see that this is a very fresh repo (first commit was around 18 days ago at the time of this writing). It appears that it went through a few days of rapid development but has slowed down a bit. Are y'all still working on updating the SDK at all, or is development complete for the foreseeable future?

If there is any ongoing development, do you have any public documentation around what features are still being added or changed? Similarly, I assume since this is open-source y'all would accept PR's from outside of the featurehub organization (within reason), but I wanted to verify that assumption.

Thanks in advance for any info you can provide! And thanks again for developing this SDK, it's really great.

The polling implementation passes the context in the URL, and it should be passed in the x-featurehub header.

Is your feature request related to a problem? Please describe.
As a Feature Hub consumer, from a (security standpoint) seeing the API key consistently logged raises security concerns.

Describe the solution you'd like
It would be nice to be able to disable API key logging either via an environment variable or flag in the Feature Hub UI.

Describe alternatives you've considered
Creating a custom logging wrapper that extrapolates relevant information and removes the API key from all transmitted logs.

Additional context
Add any other context or screenshots about the feature request here.

Hi @rvowles

I think this question is unrelated to how SDK implemented but worth checking.

When implementing polling, I notice response status is always 236 which implies stale environment as documented in https://docs.featurehub.io/featurehub/latest/sdks-development.html. The polling task get cancelled as the result. I tried to poll again few times eg config.new_context.build.feature("FLAG") but it still returns 236 regardless.

Any ideas why?

Thanks

I know we chatted about this briefly in a previous issue, but I wanted to get it documented on its own. This client currently doesn't support the GA integration that other FeatureHub SDKs do support. Is there an outline for how to add GA support to this SDK? Is it on the roadmap to add GA support to this SDK?

Thanks for any information!

Hi @rvowles 👋

Existing README is sparse so I guess I will double check here. How do you update feature flag using this SDK? I can update feature state using FeatureHubRepository#notify but can't see how the state is synced upstream to FeatureHub.

Am I right to think that current SDK doesn't have this ability?

Thanks