Invisible text on signup/login fields about feathers-chat HOT 7 CLOSED

I have tracked the problem down to the padding style in chat.css:

main.login fieldset input,
main.signup fieldset input{
  width: 100%;
  padding: 1.4em 0.7em;
}

If you comment out the padding here, all is good (even in Firefox).

So this is why it only seems to affect those two pages.

from feathers-chat.

Did we land a fix for this? I noticed this as well but can't remember is somebody submitted a PR with the changes already (I don't think I saw one).

from feathers-chat.

I didn't really know why that padding style was there in the first place, or if it was necessary, so I didn't want to submit a change that removed it. But for my local testing, that's the quick work around that I made for now.

It looks like that css stuff hasn't changed since @ekryski first added the css, so it may come from an upstream css file somewhere that has since been fixed or improved. At least it doesn't seem to be a recent change. Perhaps it has never worked on Firefox or there has been a change in Firefox since it was first committed.

I don't know enough about padding on input fields to suggest a change. I haven't tried other values (like perhaps 1.4em 1.0em might work fine here). At this point, I just know that one workaround is to remove the padding style from main.login fieldset input and main.signup fieldset input, those two styles I quoted above.

from feathers-chat.

If it doesn't change the behaviour in Chrome it would be great if you could submit the fix as a PR. I did notice some weirdness in Firefox, too but never followed up on it.

/cc @ekryski

from feathers-chat.

No problem, submitted PR #39 with the workaround I've used.

from feathers-chat.

Thanks @appurist! Merging now. :)

from feathers-chat.

Closed via #39

from feathers-chat.