Comments (4)
This error usually happens when
- You did not update
src/authentication.*
file with the GitHub strategy according to the guide? - The profile does not have an email address
from feathers-chat.
In that case the code from customizing the service has to be adjusted to work with the data you are getting. Simplest would be to only use the githubId
or customizing the data you want from the profile:
exports.Users = class Users extends Service {
create (data, params) {
// This is the information we want from the user signup data
const { githubId } = data;
// The complete user
const userData = {
githubId
};
// Call the original `create` method with existing `params` and new data
return super.create(userData, params);
}
};
from feathers-chat.
@daffl thank you for the fast reply! It turns out that GH auth is actually working. As you pointed out, the issue is that my GH profile is not providing my email in the response. I have my email set to private - perhaps that's why. The error is coming from the call to email.toLowerCase()
in users.class.js.
from feathers-chat.
thanks! That's what I was about to do. I first confirmed that the private email was, in fact, the issue.
from feathers-chat.
Related Issues (20)
- oauth github sign in HOT 4
- How would the front end connect to a remote backend? HOT 2
- Example 'app.publish is not a function' HOT 1
- Upgrading Helmet to the next major version
- Page is blank because scripts are blocked by browser security HOT 8
- Initial click on "Sign up and log in" fails with No record found for id '1' HOT 1
- app.listen(...).on is not a function HOT 1
- Test configuration not working HOT 1
- clear install ReferenceError: feathers is not defined HOT 1
- Cannot find module 'feathers-chat' or its corresponding type declarations. HOT 5
- [FR] first class module support HOT 1
- [fr] make app.ts export an asynchronous function HOT 4
- oauth github fails with `error: BadRequest: validation failed` HOT 5
- Workflows breaks Cloud IDE's HOT 1
- [perf] Database migration takes 40 seconds with an empty database HOT 1
- [FR] More DX improvements
- [FR] Support ESM out of the box
- Feathers Chat MySQl/MariaDB version
- Sample Chat Not Working for MongoDB HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from feathers-chat.