Cannot get github auth working about feathers-chat HOT 4 CLOSED

This error usually happens when

• You did not update src/authentication.* file with the GitHub strategy according to the guide?
• The profile does not have an email address

from feathers-chat.

In that case the code from customizing the service has to be adjusted to work with the data you are getting. Simplest would be to only use the githubId or customizing the data you want from the profile:

exports.Users = class Users extends Service {
  create (data, params) {
    // This is the information we want from the user signup data
    const { githubId } = data;

    // The complete user
    const userData = {
      githubId
    };

    // Call the original `create` method with existing `params` and new data
    return super.create(userData, params);
  }  
};

from feathers-chat.

@daffl thank you for the fast reply! It turns out that GH auth is actually working. As you pointed out, the issue is that my GH profile is not providing my email in the response. I have my email set to private - perhaps that's why. The error is coming from the call to email.toLowerCase() in users.class.js.

from feathers-chat.

thanks! That's what I was about to do. I first confirmed that the private email was, in fact, the issue.

from feathers-chat.