Giter Club home page Giter Club logo

pipi's People

Contributors

fcyu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

pipi's Issues

My question

I have only one question: why such an excellent paper was not published in Nature?

Low robustness to the presence of unknown amino-acid in the protein sequence

Proteins sequences present in Fasta files may include -not too rarely- undetermined amino-acids (often marked as * ).
It seems PIPI does not behave well when encountering a symbol in a protein sequence that is not described in its own internal amino-acid list, and crashes as reported below.

issue_pipi-1 2 8_undetermined_amino_acid

It would probably better if the software could just at least remove this specific protein from the database, warns the user, and pursue the rest of the processing.

Unimod.txt file in PIPI-1.2.8 release

It seems a Post-Translational-Modification file is needed to run PIPI.

This file is however missing in PIPI-1.2.8 release -leading to PIPI crash-, and no mention is made of it or any instruction given in the Readme to build your own.

issue_pipi-1 2 8_missing_unimod_file

The file can however be found in GitHub sources.

Incomplete parameters.def file in PIPI-1.2.8 release

The parameter file provided in the 1.2.8 release of PIPI is missing the following lines that are present in the source code version of the same file:

min_potential_charge = 2
max_potential_charge = 4

Here is the detailed error obtained running the software:
issue_pipi-1 2 8_missing_parameter

Searching the source code reveals the error being due to missing parameters; adding them worked.
Not sure if the software is intended to work with default values if not provided, but in the current case it just throws back an exception related to the unfound values.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.