fbreckle / go-netbox Goto Github PK

Hi!

I'm trying to unset the role of WritableIPAddress, but it seems not to work.

Snippet (part of a Terraform provider)

if d.HasChange("role") {
  if role := d.Get("role"); role.(string) == "" {
	  data.Role = " "
  } else {
	  data.Role = role.(string)
  }
}

This snippet above ends in map[role:[ is not a valid choice.]] but it should be null because the field is omitempty tagged.

Hi,

I want to implement the tags filter in e-breuninger/netbox. But right now it supports only one tag per request. But most Netbox objects needs to filtered by multiple tags such as environment and service.

For example (taken from netbox/client/virtualization/virtualization_virtual_machines_list_parameters.go)

if err := r.SetQueryParam("tag", qTag); err != nil {
  return err
}

Hi,

As of https://github.com/netbox-community/netbox/pull/9571/files , the u_height field in netbox is no longer an integer. As such, when creating or reading device types with this library (and notably the terraform provider), we receive

Error: json: cannot unmarshal number 1.0 into Go struct field DeviceType.u_height of type int64

Hopefully this should be a minor change here https://github.com/fbreckle/go-netbox/blob/master/netbox/models/device_type.go#L117 , unless anyone is aware of anywhere else this needs changing?

I'll hopefully get a PR written and tested in the next few days

Mike