Giter Club home page Giter Club logo

pe's People

Contributors

fatclarence avatar

Watchers

 avatar

pe's Issues

Invalid URL can be added with add command

Summary:
An invalid URL can be added as a bookmark. Eg. "https://monkey" "https://google"

Steps to reproduce:

  1. type "add n/monkeys u/https://google r/Module planner t/school t/timetable

Expected results:
Throw invalid url error because the url is invalid.

Actual results:
Result displays show success message:
"New bookmark added: monkeys URL: https://google Remark: Module planner Folder: ROOT Tags: [school][timetable]"

Screenshot of issue:

Screenshot 2019-11-15 at 5.09.10 PM.png

"favourite 1" is not a valid command as described in Developer Guide

Summary:
Developer guide states in F13 that I can favourite a bookmark by typing "favourite 1" or "fav 1". "fav 1" works, but "favourite 1" does not and returns "Unknown Command" in result display.

Steps to reproduce:

  1. type "list" into command box
  2. type "favourite 1"

Expected results:
Bookmark added to Favorites: Mark User Guide URL: https://ay1920s1-cs2103t-t13-4.github.io/main/ Remark: User guide for Mark Folder: ROOT Tags:

The above should be displayed in my Result Display.

Actual results:
Unknown Command

This was displayed instead.

Screenshot of issue:

Screenshot 2019-11-15 at 4.43.23 PM.png

Developer guide information shown above

Screenshot 2019-11-15 at 4.43.41 PM.png

Unsuccessful running of the command

Annote-delete command does not throw error

Summary:
typing "annotate-delete 1 p/all" should allow me to delete my first annotation. But if I have yet to make any annotations it should have thrown an error. But the error was only caught internally.

Steps to reproduce:

  1. type "annotate-delete 1 p/all"

Expected results:
Offline copy of the first bookmark is clear of any annotations.

Actual results:
Nothing.

Screenshot of issue:
Screenshot 2019-11-15 at 5.14.06 PM.png

Editing my folder name to non-alphanumeric characters does not return any response in GUI

Summary:
Tried to create a folder with 我爱新加坡, using "folder 我爱新加坡" and it threw the invalid command error. However when I try to edit the folder from a valid name of "School" to 我爱新加坡, I was not returned any response from the GUI. Error was only reflected internally.

Steps to reproduce:

  1. type "folder school"
  2. type "folder-edit school t/我爱新加坡"

Expected results:
Invalid command format!
folder: Creates a new folder with the specified name.
Parameters: NAME (must not be an existing folder name) p/[PARENT_FOLDER]
Example: folder school

Actual results:
Nothing was returned in the GUI

Screenshot of issue:

Screenshot 2019-11-15 at 4.58.48 PM.png

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.