fastjur / oopp-b1 Goto Github PK

Should the thread not close after case "logout" in ClientConnectionThread.handleMessage?

The server keeps the connection open even though the server is turned off and starts using 100% of the CPU, indicating a stuck loop?

Steps to reproduce:

• Start Server (not the test server, actual server)
• Connect and login a client
• Kill the client
• Watch Server burn your CPU

After coding for a couple of hours I had about 20 instances of server still running

There are a couple of things wrong:

• First/lastname are stored separately in the database, either implement a function in the GUI that recognizes this, or make 2 fields
• Sex: Currently stored as male or female in the database. Make this a dropdown instead of textfield?
• Age: Is this necessary to display on your own profile page?
• Date of Birth: Make this a dateselector? Easiest would be if it outputs a unix timestamp, as this is how it gets stored in the database
• Nationality/languages/study: Should be a dropdown, this dropdown gets the data live from the database upon page load, this is important to get ID's etc. due to constraints set in the database. Make it a dropdown, I will fill in the data
• Languages: There are multiple options available here, checkboxes?
• Address: Not stored in database AFAIK, neither in the user object. Only latitude and longitude are used for distance calculation
• Password: Should be a masked field.
• Find a tutor/become a tutor/find a study buddy: These should be filled with live courses from the database upon page load. Also: What is your take on the "Find a tutor" fields in the profile? Shouldn't this be a list of checkboxes or something? One should be able to find buddies etc. for different courses

Currently not checking on distance due to user not being able to set maxdistance

Only "Sinter Klaas" gets returned (3 times).

TopBar FindMatch selector should be set to active.

Labels are cutoff. See image:

Backend.isConnected() always returns true, but is used in other methods.

Whenever one makes a new user, the default age is set at 46, this should be null.