Giter Club home page Giter Club logo

Comments (7)

ronenfe avatar ronenfe commented on May 30, 2024 1

Confirmed to work, thanks for the fast fix.

from aws-signature-version-4.

github-actions avatar github-actions commented on May 30, 2024

Hi there and welcome to this repository!

A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it.

from aws-signature-version-4.

FantasticFiasco avatar FantasticFiasco commented on May 30, 2024

Hi @ronenfe and thanks for reporting this.

A couple of questions helping me reproduce this:

  1. Is request targeting a recipient that is available on the network? I.e. should the request succeed but instead hangs?
  2. Does it hang forever or does it finally throw an exception?

from aws-signature-version-4.

ronenfe avatar ronenfe commented on May 30, 2024

Yes, this code works if I copy the signing code out of the nuget and put it inside my project and make all calls sync except the call for the original httpclient which I use for it .ConfigureAwait(false).GetAwaiter().GetResult() because it also doesn't have a sync send for .net 4.x Maybe adding another method for sync signing in the nuget will work. I did a pull request on the other nuget for aws singing which I was part of writing it, but the owner doesn't approve it because he thinks it's unsafe , maybe you want to implement it the same way. tsibelman/aws-signer-v4-dot-net#37 (comment)
The code never returns from the nuget, no exception, it just get hung.

from aws-signature-version-4.

FantasticFiasco avatar FantasticFiasco commented on May 30, 2024

I've found the bug and will start working on fixing it in the upcoming days. Thanks for reporting it!

from aws-signature-version-4.

FantasticFiasco avatar FantasticFiasco commented on May 30, 2024

This issue has now been fixed in v3.0.1. Thank you for reporting this issue!

from aws-signature-version-4.

ronenfe avatar ronenfe commented on May 30, 2024

from aws-signature-version-4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.