Giter Club home page Giter Club logo

Comments (6)

FantasticFiasco avatar FantasticFiasco commented on May 30, 2024 1

Hi @Timovzl, I'll look into the issue tonight.

from aws-signature-version-4.

Timovzl avatar Timovzl commented on May 30, 2024 1

@FantasticFiasco I have created a PR to help speed things along. I did not have time to change the commit message to adhere to your guidelines 100%, so feel free to use the PR as you see fit. If you prefer to reject it and use it for inspiration only, perfect. I hope it's of help.

from aws-signature-version-4.

FantasticFiasco avatar FantasticFiasco commented on May 30, 2024 1

Release v2.1.1 is now live, thank you so much for your contribution!

from aws-signature-version-4.

FantasticFiasco avatar FantasticFiasco commented on May 30, 2024 1

If you're happy, I'm happy 😀

It was after all a feature you yourself implemented, which to many open source project is rare and extremely valuable!

I might update README.md to mention the support for synchronous requests, just to highlight it.

from aws-signature-version-4.

github-actions avatar github-actions commented on May 30, 2024

Hi there and welcome to this repository!

A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it.

from aws-signature-version-4.

Timovzl avatar Timovzl commented on May 30, 2024

My pleasure. I'm glad you are providing this library, as AWS signing turned out to be much more complex than anticipated.

I just realized that with this addition, the package provides something unique: Truly synchronous access to AWS resources over HTTPS, without resorting to sync-over-async.

Unique because, for example, all available ElasticSearch client packages use HttpClient, but none of them have accounted for its (relatively new) synchronous APIs. As such, using such a package synchronously requires sync-over-async, which does not scale at all. That leaves manual use of the HttpClient as the only way to achieve proper synchronous operation. That leaves you with the problem of handling AWS signing. This package resolves the problem. :)

from aws-signature-version-4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.